Skip to content

Commit e95f350

Browse files
committed
Fix missing resource attributes
1 parent 83d2a54 commit e95f350

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

src/Elastic.OpenTelemetry.AutoInstrumentation/AutoInstrumentationPlugin.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ public TracerProviderBuilder BeforeConfigureTracerProvider(TracerProviderBuilder
4444

4545
builder.ConfigureServices(sc => sc.Configure<OtlpExporterOptions>(OtlpExporterDefaults.OtlpExporterOptions));
4646

47-
CoreTracerProvderBuilderExtensions.AddActivitySourceWithLogging(builder, logger, "Elastic.Transport", "<n/a>");
48-
CoreTracerProvderBuilderExtensions.AddElasticProcessorsCore(builder, null, _components, null);
47+
TracerProvderBuilderExtensions.AddActivitySourceWithLogging(builder, logger, "Elastic.Transport", "<n/a>");
48+
TracerProvderBuilderExtensions.AddElasticProcessorsCore(builder, null, _components, null);
4949

5050
logger.LogConfiguredSignalProvider("Traces", nameof(TracerProviderBuilder), "<n/a>");
5151

src/Elastic.OpenTelemetry.Core/Extensions/ResourceBuilderExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ internal static ResourceBuilder WithElasticDefaultsCore(
3333
Action<ResourceBuilder, BuilderState>? configure) =>
3434
WithElasticDefaultsCore(builder, builderState.Components, services, configure);
3535

36-
internal static ResourceBuilder WithElasticDefaultsCore
37-
(this ResourceBuilder builder,
36+
internal static ResourceBuilder WithElasticDefaultsCore(
37+
this ResourceBuilder builder,
3838
ElasticOpenTelemetryComponents components,
3939
IServiceCollection? services,
4040
Action<ResourceBuilder, BuilderState>? configure)

src/Elastic.OpenTelemetry.Core/Extensions/TracerProvderBuilderExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace OpenTelemetry.Trace;
2121
/// Provides extension methods on the <see cref="TracerProviderBuilder"/> used to register
2222
/// the Elastic Distribution of OpenTelemetry (EDOT) .NET defaults.
2323
/// </summary>
24-
public static class CoreTracerProvderBuilderExtensions
24+
internal static class TracerProvderBuilderExtensions
2525
{
2626
private static int AddElasticProcessorsCallCount;
2727

src/Elastic.OpenTelemetry.Core/SignalBuilder.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,11 @@ public static T WithElasticDefaults<T>(
143143
components = ElasticOpenTelemetry.Bootstrap(options, services);
144144
builderState = new BuilderState(components, instanceId);
145145

146-
components.Logger.LogStoringBuilderState(providerBuilderName, instanceId);
146+
configure(builder, builderState, services);
147147

148+
components.Logger.LogStoringBuilderState(providerBuilderName, instanceId);
148149
BuilderStateTable.Add(builder, builderState);
149150
}
150-
151-
configure(builder, builderState, services);
152151
}
153152
catch (Exception ex)
154153
{

src/Elastic.OpenTelemetry/Extensions/ResourceBuilderExtensions.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using Elastic.OpenTelemetry.Diagnostics;
88
using Elastic.OpenTelemetry.Instrumentation;
99
using Microsoft.Extensions.DependencyInjection;
10+
using Elastic.OpenTelemetry.Resources;
1011

1112
#if NET
1213
using System.Runtime.CompilerServices;
@@ -38,7 +39,7 @@ internal static ResourceBuilder WithElasticDefaults(this ResourceBuilder builder
3839

3940
components.Logger.LogWithElasticDefaultsCallCount(callCount, nameof(ResourceBuilder));
4041

41-
return SignalBuilder.WithElasticDefaults(builder, components.Options, components, services, (b, bs, _) => ConfigureBuilder(b, bs));
42+
return builder.WithElasticDefaultsCore(components, services, ConfigureBuilder);
4243
}
4344

4445
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026", Justification = "The call to `AssemblyScanning.AddInstrumentationViaReflection` " +

src/Elastic.OpenTelemetry/Extensions/TracerProviderBuilderExtensions.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,14 +164,14 @@ private static void ConfigureBuilder(TracerProviderBuilder builder, BuilderState
164164
}
165165
else
166166
{
167-
CoreTracerProvderBuilderExtensions.AddActivitySourceWithLogging(builder, logger, "System.Net.Http", builderState.InstanceIdentifier);
167+
TracerProvderBuilderExtensions.AddActivitySourceWithLogging(builder, logger, "System.Net.Http", builderState.InstanceIdentifier);
168168
}
169169
#else
170170
AddWithLogging(builder, logger, "HTTP", b => b.AddHttpClientInstrumentation(), builderState.InstanceIdentifier);
171171
#endif
172172

173173
AddWithLogging(builder, logger, "GrpcClient", b => b.AddGrpcClientInstrumentation(), builderState.InstanceIdentifier);
174-
CoreTracerProvderBuilderExtensions.AddActivitySourceWithLogging(builder, logger, "Elastic.Transport", builderState.InstanceIdentifier);
174+
TracerProvderBuilderExtensions.AddActivitySourceWithLogging(builder, logger, "Elastic.Transport", builderState.InstanceIdentifier);
175175

176176
// NOTE: Despite them having no dependencies. We cannot add the OpenTelemetry.Instrumentation.ElasticsearchClient or
177177
// OpenTelemetry.Instrumentation.EntityFrameworkCore instrumentations here, as including the package references causes
@@ -186,7 +186,7 @@ private static void ConfigureBuilder(TracerProviderBuilder builder, BuilderState
186186
SignalBuilder.AddInstrumentationViaReflection(builder, components, ContribTraceInstrumentation.GetReflectionInstrumentationAssemblies(), builderState.InstanceIdentifier);
187187
}
188188

189-
CoreTracerProvderBuilderExtensions.AddElasticProcessorsCore(builder, builderState, null, services);
189+
TracerProvderBuilderExtensions.AddElasticProcessorsCore(builder, builderState, null, services);
190190

191191
if (components.Options.SkipOtlpExporter)
192192
{

0 commit comments

Comments
 (0)