Skip to content

Commit 4c6ff80

Browse files
authored
ci: use secrets from the source of truth (#112)
1 parent 8526dff commit 4c6ff80

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

.github/workflows/e2e.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ concurrency:
2525
env:
2626
# (keep_serverless-staging-oblt, keep_serverless-qa-oblt or serverless-production-oblt)
2727
SERVERLESS_PROJECT: serverless-production-oblt
28-
# Secrets managed through IasC, if you need a different environment please reach the obs robots team
29-
## TODO: Use Keyless
30-
E2E__BROWSEREMAIL: ${{ secrets.OBSERVABILITY_EC_USERNAME }}
31-
E2E__BROWSERPASSWORD: ${{ secrets.OBSERVABILITY_EC_PASSWORD }}
3228

3329
# NOTE: if you add a new job and it's a mandatory check then
3430
# update e2e-docs.yml
@@ -51,6 +47,13 @@ jobs:
5147
github-token: ${{ secrets.OBLT_CLI_GITHUB_TOKEN }}
5248
cluster-name: ${{ env.SERVERLESS_PROJECT }}
5349

50+
- uses: google-github-actions/get-secretmanager-secrets@dc4a1392bad0fd60aee00bb2097e30ef07a1caae # v2.1.3
51+
with:
52+
export_to_environment: true
53+
secrets: |-
54+
E2E__BROWSEREMAIL:elastic-observability/elastic-cloud-observability-team-pro-username
55+
E2E__BROWSERPASSWORD:elastic-observability/elastic-cloud-observability-team-pro-password
56+
5457
- name: End-to-end tests
5558
run: ./build.sh test --test-suite=e2e
5659
env:

0 commit comments

Comments
 (0)