You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once you have your environment set up and have completed a clean run of the unit
409
414
tests you can get to work :tada: .
@@ -451,7 +456,7 @@ tests you can get to work :tada: .
451
456
running `make test` again. You can then commit the generated files as part of your
452
457
PR.
453
458
454
-
## Asking for help
459
+
###Asking for help
455
460
456
461
If you need help at any stage of your work, please don't hesitate to ask!
457
462
@@ -462,15 +467,15 @@ If you need help at any stage of your work, please don't hesitate to ask!
462
467
463
468
- If you are struggling with something while working on your PR, or aren't quite
464
469
sure of your approach, you can open a [draft](https://github.blog/2019-02-14-introducing-draft-pull-requests/)
465
-
(prefix the title with `WIP:`) and explain what you are thinking.
470
+
(prefix the title with `WIP:`) and explain what you are thinking.
466
471
You can tag in one of the core team, or drop the PR link into [slack](https://weave-community.slack.com/messages/eksctl/) and get
467
472
help from the community.
468
473
469
474
- We are happy to pair with contributors over a slack call to help them fine-tune their
470
475
implementation. You can ping us directly, or head to the [channel](https://weave-community.slack.com/messages/eksctl/)
471
476
to see if anyone in the community is up for being a buddy :smiley: .
472
477
473
-
## PR submission guidelines
478
+
###PR submission guidelines
474
479
475
480
Push your changes to the branch on your fork and submit a pull request to the original repository
476
481
against the `main` branch.
@@ -527,13 +532,12 @@ PRs which adhere to our guidelines are more likely to be accepted
527
532
1.**There are well-written commit messages** ([see below](#commit-message-formatting))
528
533
which will make future debugging fun.
529
534
530
-
531
535
In general, we will merge a PR once a maintainer has reviewed and approved it.
532
536
Trivial changes (e.g., corrections to spelling) may get waved through.
533
537
For substantial changes, more people may become involved, and you might get asked to resubmit the PR or divide the
534
538
changes into more than one PR.
535
539
536
-
### Commit message formatting
540
+
####Commit message formatting
537
541
538
542
_For more on how to write great commit messages, and why you should, check out
539
543
[this excellent blog post](https://cbea.ms/git-commit/)._
@@ -579,9 +583,9 @@ This allows the message to be easier to read on GitHub as well as in various git
579
583
580
584
---
581
585
582
-
# How the Maintainers process contributions
586
+
##How the Maintainers process contributions
583
587
584
-
## Prioritizing issues
588
+
###Prioritizing issues
585
589
586
590
The core team regularly processes incoming issues. There may be some delay over holiday periods.
587
591
@@ -614,14 +618,14 @@ Every issue will be assigned a `priority/<x>` label. The levels of priorities ar
614
618
615
619
These priority categories have been inspired by [the Kubernetes contributing guide](https://github.com/kubernetes/community/blob/master/contributors/guide/issue-triage.md).
616
620
617
-
## Reviewing PRs
621
+
###Reviewing PRs
618
622
619
623
The core team aims to clear the PR queue as quickly as possible. Community members
620
624
should also feel free to keep an eye on things and provide their own thoughts and expertise.
621
625
622
626
---
623
627
624
-
# Proposals
628
+
##Proposals
625
629
626
630
For chunky features which require Serious Thought™, the first step is the submission
627
631
of a design proposal to the [docs](docs/) folder through the standard PR process.
@@ -694,4 +698,4 @@ Each proposal/design doc should cover the following _at a minimum_:
694
698
695
699
---
696
700
697
-
# :rocket::tada: Thanks for reading! :tada::rocket:
701
+
##:rocket::tada: Thanks for reading! :tada::rocket
0 commit comments