Skip to content

Commit 542aeb7

Browse files
committed
cleanup of readme and contributing docs, fixed formatting and typos
1 parent 279a71f commit 542aeb7

File tree

3 files changed

+120
-96
lines changed

3 files changed

+120
-96
lines changed

CODE_OF_CONDUCT.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## Community Code of Conduct
1+
# Community Code of Conduct
22

33
eksctl follows the [CNCF Code of Conduct](https://github.com/cncf/foundation/blob/master/code-of-conduct.md).
44

CONTRIBUTING.md

+54-50
Original file line numberDiff line numberDiff line change
@@ -21,33 +21,34 @@ right at the top: **Always be kind!**
2121

2222
Looking forward to seeing you in the repo! :sparkles:
2323

24-
# Table of Contents
24+
## Table of Contents
2525

2626
- [Legal bits](#legal-bits)
2727
- [Where can I get involved?](#where-can-i-get-involved)
28-
- [The eksctl roadmap](#the-eksctl-roadmap)
28+
- [The eksctl roadmap](#the-eksctl-roadmap)
2929
- [Opening Issues](#opening-issues)
30-
- [Bug report guide](#bug-report-guide)
31-
- [Feature request guide](#feature-request-guide)
32-
- [Help request guide](#help-request-guide)
30+
- [Bug report guide](#bug-report-guide)
31+
- [Feature request guide](#feature-request-guide)
32+
- [Help request guide](#help-request-guide)
3333
- [Submitting PRs](#submitting-prs)
34-
- [Choosing something to work on](#choosing-something-to-work-on)
35-
- [Developing eksctl](#developing-eksctl)
36-
- [Asking for help](#asking-for-help)
37-
- [PR submission guidelines](#pr-submission-guidelines)
34+
- [Choosing something to work on](#choosing-something-to-work-on)
35+
- [Developing eksctl](#developing-eksctl)
36+
- [Asking for help](#asking-for-help)
37+
- [PR submission guidelines](#pr-submission-guidelines)
3838
- [How the Maintainers process contributions](#how-the-maintainers-process-contributions)
39-
- [Prioritizing issues](#prioritizing-issues)
40-
- [Reviewing PRs](#reviewing-prs)
39+
- [Prioritizing issues](#prioritizing-issues)
40+
- [Reviewing PRs](#reviewing-prs)
4141
- [Proposals](#proposals)
4242

4343
---
4444

45-
# Legal bits
45+
## Legal bits
46+
47+
### License
4648

47-
## License
4849
`eksctl` is [Apache 2.0 licensed](LICENSE).
4950

50-
## Certificate of Origin
51+
### Certificate of Origin
5152

5253
By contributing to this project you agree to the Developer Certificate of
5354
Origin (DCO). This document was created by the Linux Kernel community and is a
@@ -57,19 +58,19 @@ contribution. No action from you is required, but it's a good idea to see the
5758

5859
---
5960

60-
# Where can I get involved?
61+
## Where can I get involved?
6162

6263
We are happy to see people in pretty much all areas of eksctl's development.
6364
Here is a non-exhaustive list of ways you can help out:
6465

65-
1. Open a [PR](#submitting-prs). :woman_technologist:
66+
1. Open a [PR](#submitting-prs).
6667

6768
Beyond fixing bugs and submitting new features, there are other things you can submit
6869
which, while less flashy, will be deeply appreciated by all who interact with the codebase:
6970

70-
- Backfilling tests! (our coverage is super low right now.)
71-
- Refactoring! (omigod such tech debt.)
72-
- Reviewing and updating [documentation](https://eksctl.io/)! (seems to be we only notice the documentation that doesn't exist.)
71+
- Backfilling tests!
72+
- Refactoring!
73+
- Reviewing and updating [documentation](https://eksctl.io/)!
7374

7475
(See also [Choosing something to work on](#choosing-something-to-work-on) below.)
7576
1. Open an [issue](#opening-issues). :interrobang:
@@ -83,9 +84,9 @@ Here is a non-exhaustive list of ways you can help out:
8384
1. Review old issues; poke or suggest closing ones which are stale or follow up those which still look good. :speech_balloon:
8485
1. Think deeply about the future of `eksctl`, then [talk about it](#proposals). :crystal_ball:
8586

86-
## The eksctl roadmap
87+
### The eksctl roadmap
8788

88-
... can be found [here](https://eksctl.io/community/).
89+
`eksctl` roadmap can be found [here](https://eksctl.io/community/).
8990

9091
This is the general long game we are playing. Contributions which steer us further towards
9192
these overarching goals will be enthusiastically welcomed, while contributions which are
@@ -95,7 +96,7 @@ For bonus points, please highlight how feature requests/PRs fit into the roadmap
9596

9697
---
9798

98-
# Opening Issues
99+
## Opening Issues
99100

100101
These guides aim to help you write issues in a way which will ensure that they are processed
101102
as quickly as possible.
@@ -121,11 +122,12 @@ _See below for [how issues are prioritized](#prioritizing-issues)_.
121122
everyone's negativity bias, so throw in some emoji when in doubt :+1: :smiley: :rocket: :tada:.
122123

123124
**Dedicated guides**:
125+
124126
- [Bug report guide](#bug-report-guide)
125127
- [Feature request guide](#feature-request-guide)
126128
- [Help request guide](#help-request-guide)
127129

128-
## Bug report guide
130+
### Bug report guide
129131

130132
We hope to get to bug reports within a couple of working days, but please wait for at least
131133
7 before nudging. (Unless it is a super critical end-of-the world bug, then by all means
@@ -166,15 +168,15 @@ information. Add more that what is asked for if you can :smiley:.
166168
1. If you already have a fix in mind, note that on the report and go ahead and open a
167169
PR whenever you are ready. A core team-member will assign the issue to you.
168170

169-
## Feature request guide
171+
### Feature request guide
170172

171173
We hope to respond to and prioritize new feature requests within 7 working days. Please wait for
172174
up to 14 before nudging us.
173175

174176
A feature request is the start of a discussion, so don't be put off if it is not
175177
accepted. Features which either do not contribute to or directly work against
176-
the project [goals](#the-eksctl-vision) will likely be rejected, as will highly
177-
specialised usecases.
178+
the project goals will likely be rejected, as will highly
179+
specialised use-cases.
178180

179181
Once you have opened the ticket, feel free to post it in the community
180182
[slack channel](https://weave-community.slack.com/messages/CAYBZBWGL/) to get more opinions on it.
@@ -190,7 +192,7 @@ Below are the steps we encourage people to take when creating a new feature requ
190192
nicely with [code blocks](https://docs.github.com/en/free-pro-team@latest/github/writing-on-github/creating-and-highlighting-code-blocks).
191193
If you have strong ideas, be as detailed as you like.
192194

193-
1. Explain how this feature would work towards the [project's vision](#the-eksctl-vision),
195+
1. Explain how this feature would work towards the project's vision,
194196
or how it would benefit the community.
195197

196198
1. Note the deliverable of this issue: should the outcome be a simple PR to implement the
@@ -200,7 +202,7 @@ Below are the steps we encourage people to take when creating a new feature requ
200202
a solution in mind, explain what you plan to do on the issue and open a PR!
201203
A core team member will assign the task to you.
202204

203-
## Help request guide
205+
### Help request guide
204206

205207
While you can ask for general help with `eksctl` usage in the [slack channel](https://weave-community.slack.com/messages/CAYBZBWGL/),
206208
opening an issue creates a more searchable history for the community.
@@ -226,8 +228,9 @@ Please following these steps when opening a new help issue:
226228

227229
---
228230

229-
# Submitting PRs
230-
## Choosing something to work on
231+
## Submitting PRs
232+
233+
### Choosing something to work on
231234

232235
If you are not here to report a bug, ask for help or request some new behaviour, this
233236
is the section for you. We have curated a set of issues for anyone who simply
@@ -256,9 +259,10 @@ wants to build up their open-source cred :muscle:.
256259
- All other issues labelled `kind/<x>` or `priority/<x>` are also up for grabs, but
257260
are likely to require a fair amount of context.
258261

259-
## Developing eksctl
262+
### Developing eksctl
260263

261264
**Sections:**
265+
262266
- [Getting started](#getting-started)
263267
- [Setting up your Go environment](#setting-up-your-go-environment)
264268
- [Forking the repo](#forking-the-repo)
@@ -270,13 +274,13 @@ wants to build up their open-source cred :muscle:.
270274
> WARNING: All commands in this section have only been tested on Linux/Unix systems.
271275
> There is no guarantee that they will work on Windows.
272276
273-
### Getting started
277+
#### Getting started
274278

275279
Before you begin writing code, you may want to have a play with `eksctl` to get familiar
276280
with the tool. Check out the [README](README.md) for basic installation and usage,
277281
then head to the [main docs](https://eksctl.io/) for more information.
278282

279-
### Setting up your Go environment
283+
#### Setting up your Go environment
280284

281285
This project is written in Go. To be able to contribute you will need:
282286

@@ -289,7 +293,7 @@ This project is written in Go. To be able to contribute you will need:
289293
3. (Optional) [User documentation](https://eksctl.io) is built and generated with [mkdocs](https://www.mkdocs.org/).
290294
Please make sure you have python3 and pip installed on your local system.
291295

292-
### Forking the repo
296+
#### Forking the repo
293297

294298
Make a fork of this repository and clone it by running:
295299

@@ -303,18 +307,18 @@ It is not recommended to clone under your `GOPATH` (if you define one), otherwis
303307
You may also want to add the original repo to your remotes to keep up to date
304308
with changes.
305309

306-
### Building eksctl
310+
#### Building eksctl
307311

308312
> NOTE: If you are working on Windows, you cannot use `make` at the moment,
309313
> as the `Makefile` is currently not portable.
310314
> However, if you have Git and Go installed, you can still build a binary
311315
> and run unit tests.
316+
>
312317
> ```
313318
> go build .\cmd\eksctl
314319
> go test .\pkg\...
315320
> ```
316321
317-
318322
Once in your cloned repo, you can install the dependencies and build the binary.
319323
The binary will be created in the root of your repo `./eksctl`.
320324
@@ -332,7 +336,7 @@ make build-pages
332336
make serve-pages
333337
```
334338

335-
### Running the unit tests
339+
#### Running the unit tests
336340

337341
To run the tests simply run the following after `install-build-deps`:
338342

@@ -343,7 +347,7 @@ make test
343347
If you prefer to use Docker, the same way it is used in CI, you can use the
344348
following command:
345349

346-
```
350+
```bash
347351
make -f Makefile.docker test
348352
```
349353

@@ -353,7 +357,7 @@ make -f Makefile.docker test
353357
> It is recommended to use `make build` etc, unless there is an issue in CI
354358
> that need troubleshooting.
355359
356-
### Running the integration tests
360+
#### Running the integration tests
357361

358362
> NOTE: Some parts of the integration tests are not configurable and therefore
359363
> cannot be run by folks outside the core team. If you are NOT contributing to the
@@ -368,6 +372,7 @@ The integration tests are long and unfortunately there are some flakes (help is
368372
welcome!).
369373

370374
There are several ways to run the tests. Requirements are:
375+
371376
- An AWS account (it is recommended to use [gsts](https://github.com/ruimarinho/gsts) to authenticate)
372377
which you are logged in to with a session token which won't expire for at least 2 hours.
373378
- An empty repository for testing gitops operations
@@ -403,7 +408,7 @@ To run a specific suite:
403408
ginkgo -tags integration -v --progress integration/tests/<suite name>/... -- -test.v -ginkgo.v
404409
```
405410

406-
### Writing your solution
411+
#### Writing your solution
407412

408413
Once you have your environment set up and have completed a clean run of the unit
409414
tests you can get to work :tada: .
@@ -451,7 +456,7 @@ tests you can get to work :tada: .
451456
running `make test` again. You can then commit the generated files as part of your
452457
PR.
453458

454-
## Asking for help
459+
### Asking for help
455460

456461
If you need help at any stage of your work, please don't hesitate to ask!
457462

@@ -462,15 +467,15 @@ If you need help at any stage of your work, please don't hesitate to ask!
462467

463468
- If you are struggling with something while working on your PR, or aren't quite
464469
sure of your approach, you can open a [draft](https://github.blog/2019-02-14-introducing-draft-pull-requests/)
465-
(prefix the title with `WIP: `) and explain what you are thinking.
470+
(prefix the title with `WIP:`) and explain what you are thinking.
466471
You can tag in one of the core team, or drop the PR link into [slack](https://weave-community.slack.com/messages/eksctl/) and get
467472
help from the community.
468473

469474
- We are happy to pair with contributors over a slack call to help them fine-tune their
470475
implementation. You can ping us directly, or head to the [channel](https://weave-community.slack.com/messages/eksctl/)
471476
to see if anyone in the community is up for being a buddy :smiley: .
472477

473-
## PR submission guidelines
478+
### PR submission guidelines
474479

475480
Push your changes to the branch on your fork and submit a pull request to the original repository
476481
against the `main` branch.
@@ -527,13 +532,12 @@ PRs which adhere to our guidelines are more likely to be accepted
527532
1. **There are well-written commit messages** ([see below](#commit-message-formatting))
528533
which will make future debugging fun.
529534

530-
531535
In general, we will merge a PR once a maintainer has reviewed and approved it.
532536
Trivial changes (e.g., corrections to spelling) may get waved through.
533537
For substantial changes, more people may become involved, and you might get asked to resubmit the PR or divide the
534538
changes into more than one PR.
535539

536-
### Commit message formatting
540+
#### Commit message formatting
537541

538542
_For more on how to write great commit messages, and why you should, check out
539543
[this excellent blog post](https://cbea.ms/git-commit/)._
@@ -579,9 +583,9 @@ This allows the message to be easier to read on GitHub as well as in various git
579583

580584
---
581585

582-
# How the Maintainers process contributions
586+
## How the Maintainers process contributions
583587

584-
## Prioritizing issues
588+
### Prioritizing issues
585589

586590
The core team regularly processes incoming issues. There may be some delay over holiday periods.
587591

@@ -614,14 +618,14 @@ Every issue will be assigned a `priority/<x>` label. The levels of priorities ar
614618

615619
These priority categories have been inspired by [the Kubernetes contributing guide](https://github.com/kubernetes/community/blob/master/contributors/guide/issue-triage.md).
616620

617-
## Reviewing PRs
621+
### Reviewing PRs
618622

619623
The core team aims to clear the PR queue as quickly as possible. Community members
620624
should also feel free to keep an eye on things and provide their own thoughts and expertise.
621625

622626
---
623627

624-
# Proposals
628+
## Proposals
625629

626630
For chunky features which require Serious Thought™, the first step is the submission
627631
of a design proposal to the [docs](docs/) folder through the standard PR process.
@@ -694,4 +698,4 @@ Each proposal/design doc should cover the following _at a minimum_:
694698

695699
---
696700

697-
# :rocket: :tada: Thanks for reading! :tada: :rocket:
701+
## :rocket: :tada: Thanks for reading! :tada: :rocket

0 commit comments

Comments
 (0)