Skip to content

Commit 76d6ed8

Browse files
committed
Improve typespecs
1 parent f3c5881 commit 76d6ed8

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/cowboy_http_req.erl

+4-2
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,8 @@ headers(Req) ->
222222
%% returned is used as a return value.
223223
%% @see parse_header/3
224224
-spec parse_header(cowboy_http:header(), #http_req{})
225-
-> {any(), #http_req{}} | {error, badarg}.
225+
-> {any(), #http_req{}} | {undefined, binary(), #http_req{}}
226+
| {error, badarg}.
226227
parse_header(Name, Req=#http_req{p_headers=PHeaders}) ->
227228
case lists:keyfind(Name, 1, PHeaders) of
228229
false -> parse_header(Name, Req, parse_header_default(Name));
@@ -239,7 +240,8 @@ parse_header_default(_Name) -> undefined.
239240
%%
240241
%% When the header is unknown, the value is returned directly without parsing.
241242
-spec parse_header(cowboy_http:header(), #http_req{}, any())
242-
-> {any(), #http_req{}} | {error, badarg}.
243+
-> {any(), #http_req{}} | {undefined, binary(), #http_req{}}
244+
| {error, badarg}.
243245
parse_header(Name, Req, Default) when Name =:= 'Accept' ->
244246
parse_header(Name, Req, Default,
245247
fun (Value) ->

src/cowboy_http_rest.erl

+3-3
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,16 @@
2828

2929
%% Media type.
3030
content_types_p = [] ::
31-
[{{binary(), binary(), [{binary(), binary()}]}, atom()}],
31+
[{binary() | {binary(), binary(), [{binary(), binary()}]}, atom()}],
3232
content_type_a :: undefined
33-
| {{binary(), binary(), [{binary(), binary()}]}, atom()},
33+
| {binary() | {binary(), binary(), [{binary(), binary()}]}, atom()},
3434

3535
%% Language.
3636
languages_p = [] :: [binary()],
3737
language_a :: undefined | binary(),
3838

3939
%% Charset.
40-
charsets_p = [] :: [binary()],
40+
charsets_p = [] :: [{binary(), atom()}],
4141
charset_a :: undefined | binary(),
4242

4343
%% Cached resource calls.

0 commit comments

Comments
 (0)