Skip to content

singleCaseUnionMemberTranslator Translate should return null for non-applicable expressions #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MaceWindu opened this issue Aug 30, 2022 · 0 comments
Open

singleCaseUnionMemberTranslator Translate should return null for non-applicable expressions #146

MaceWindu opened this issue Aug 30, 2022 · 0 comments

Comments

@MaceWindu
Copy link

IMemberTranslator.Translate should return null for unhandled expressions, but implementation in singleCaseUnionMemberTranslator returns received expression:

EFCore.FSharp/src/EFCore.FSharp/Translations/SingleCaseUnionTranslation.fs

Line 12 in a43b78c

instance }

I don't have isolated test, but it creates issue for us here linq2db/linq2db#3743 - we receive expression after translation in place where we should receive null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaceWindu