-
Notifications
You must be signed in to change notification settings - Fork 12
feat!: Implement coupling of two or more models #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would be good to develop this multi-GPU with the expected multi-GPU inference for a single model in mind. Perhaps @cathalobrien and/or @japols can have a look at this? |
edee69e
to
e89cfe1
Compare
I see the PR has breaking changes. I think it would be helpful for the users if you include a list of the breaking changes in the PR description |
…into feature/coupling
HCookie
reviewed
Mar 13, 2025
HCookie
previously approved these changes
Mar 17, 2025
HCookie
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
config
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new command
anemoi-inference couple config.yaml
will run two or more models that requires forcing variables from each others. The models can run in different threads, different processes or different MPI ranks. They can use the same GPU (if the fit) or different GPUs.Below is a sample configuration file, that runs an atmosphere model and an ocean model: