Skip to content

fix: boundary forcings inputs #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

fix: boundary forcings inputs #226

merged 2 commits into from
May 7, 2025

Conversation

dietervdb-meteo
Copy link
Contributor

@dietervdb-meteo dietervdb-meteo commented May 6, 2025

Description

After forcings were refactored boundary_forcings_inputs was returning a list of lists, rather than a list, in the non trivial case where the checkpoint contains the output_mask supporting array. This PR fixes this.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@dietervdb-meteo dietervdb-meteo added the bug Something isn't working label May 6, 2025
@dietervdb-meteo dietervdb-meteo self-assigned this May 6, 2025
@dietervdb-meteo
Copy link
Contributor Author

I tested that the fix works.

Copy link
Member

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gmertes gmertes merged commit 02eaa6b into main May 7, 2025
65 of 74 checks passed
@gmertes gmertes deleted the fix/boundary-forcings branch May 7, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants