Skip to content

fix: extract-lam #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: extract-lam #217

merged 1 commit into from
Apr 28, 2025

Conversation

dietervdb-meteo
Copy link
Contributor

@dietervdb-meteo dietervdb-meteo commented Apr 28, 2025

Description

Extract lam output reduces the output to that of the lam region, which is defined by the cutout_mask as stored in the checkpoint. The correct supporting array is 0/lam_0/cutout_mask, in the code it was erroneously referenced as lam_0/cutout_mask. This typo is fixed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Closes #86

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@dietervdb-meteo dietervdb-meteo self-assigned this Apr 28, 2025
@dietervdb-meteo dietervdb-meteo added the bug Something isn't working label Apr 28, 2025
@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev Apr 28, 2025
@b8raoult b8raoult merged commit db81c4c into main Apr 28, 2025
75 checks passed
@github-project-automation github-project-automation bot moved this from Now In Progress to Done in Anemoi-dev Apr 28, 2025
@b8raoult b8raoult deleted the fix/extract-lam branch April 28, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix and enhance masked output
2 participants