-
Notifications
You must be signed in to change notification settings - Fork 12
fix: Inference with crps requires additional arguments in predict_step #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgt :-)
We have a CRPS runner for this, no? |
Good to know. Do you need to change the config for that? Simply running |
Yes, you'll need to use runner: crps |
But the runner was a work-around to be able to run with the old branch @gmertes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, the idea being that every (future) extra to predict step has to be a keyword argument and not a positional.
@HCookie what do you think?
Description
The problem is described in ecmwf/anemoi-core#277. The forward function of
AnemoiEnsModelEncProcDec
takes additional arguments that need to be passed from anemoi-inference.