-
Notifications
You must be signed in to change notification settings - Fork 12
feat(input): add FDB input class #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need the "request_template" part. This will be more inline with the other inputs and datasets sources
Hi @b8raoult, my understanding is that |
Removed the |
e362413
to
4a41ae4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
@frazane Happy for this to be merged?
Yes. Thanks for the support! |
Description
This PR introduces a new class to get input fields from FDB. For using it, one must specify some keys of the request as kwargs in the configuration, which are then completed/overridden by the keys (date, time, param, etc.) of the mars request for the data as specified in the checkpoint (just like in
MarsInput
). The FDB configuration can either be provided as additional key-value pairs, or as environment variables.Example config
Type of Change
Issue Number
Code Compatibility
Code Performance and Testing
Dependencies
Documentation
Additional Notes