Skip to content

fix: Remove hdate from variable keys #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: Remove hdate from variable keys #165

merged 2 commits into from
Mar 4, 2025

Conversation

gmertes
Copy link
Member

@gmertes gmertes commented Mar 4, 2025

Description

The checkpoint variables metadata might contain an hdate key in the data request, if the model was trained on hindcast data.

This key needs to be skipped when constructing the initial condition request and writing to grib.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev Mar 4, 2025
@github-actions github-actions bot added the bug Something isn't working label Mar 4, 2025
@b8raoult b8raoult merged commit c024ddf into main Mar 4, 2025
67 of 68 checks passed
@b8raoult b8raoult deleted the fix/hdate branch March 4, 2025 16:23
@github-project-automation github-project-automation bot moved this from Now In Progress to Done in Anemoi-dev Mar 4, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (90728d5) to head (3b6c477).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   98.03%   96.07%   -1.97%     
==========================================
  Files           3        3              
  Lines          51       51              
==========================================
- Hits           50       49       -1     
- Misses          1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HCookie pushed a commit that referenced this pull request Mar 11, 2025
* chore: Remove obsolete code

* fix: Remove `hdate` from input and output keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants