Skip to content

fix: Post processors #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: Post processors #164

merged 2 commits into from
Mar 4, 2025

Conversation

gmertes
Copy link
Member

@gmertes gmertes commented Mar 4, 2025

Description

  • Fixes a crash that happens when post_processors is not defined in the config.
  • Remove leftover temporary code from before we had a processor factory.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Related to #131 , the logic that facilitates the transition to not accumulating by default was broken.

Code Compatibility

  • I have performed a self-review of my code

@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev Mar 4, 2025
@github-actions github-actions bot added the bug Something isn't working label Mar 4, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (90728d5) to head (5002167).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   98.03%   96.07%   -1.97%     
==========================================
  Files           3        3              
  Lines          51       51              
==========================================
- Hits           50       49       -1     
- Misses          1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@b8raoult b8raoult merged commit c5bd6a9 into main Mar 4, 2025
69 checks passed
@b8raoult b8raoult deleted the fix/processors branch March 4, 2025 13:56
@github-project-automation github-project-automation bot moved this from Now In Progress to Done in Anemoi-dev Mar 4, 2025
HCookie pushed a commit that referenced this pull request Mar 11, 2025
* chore: Remove leftover code

* fix: Temporary accumulation post processor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants