Skip to content

fix: Rework Truth Output #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025
Merged

fix: Rework Truth Output #159

merged 3 commits into from
Mar 4, 2025

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Mar 3, 2025

Description

Override write_step instead of write_state.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Code Compatibility

  • I have performed a self-review of my code

@HCookie HCookie added the bug Something isn't working label Mar 3, 2025
@HCookie HCookie requested a review from b8raoult March 3, 2025 11:25
@HCookie HCookie self-assigned this Mar 3, 2025
@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev Mar 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (90728d5) to head (aa3272f).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   98.03%   96.07%   -1.97%     
==========================================
  Files           3        3              
  Lines          51       51              
==========================================
- Hits           50       49       -1     
- Misses          1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HCookie HCookie moved this from Now In Progress to Under Review in Anemoi-dev Mar 3, 2025
@b8raoult b8raoult merged commit 7601c2e into main Mar 4, 2025
68 checks passed
@github-project-automation github-project-automation bot moved this from Under Review to Done in Anemoi-dev Mar 4, 2025
@b8raoult b8raoult deleted the fix/truth_output branch March 4, 2025 13:57
HCookie added a commit that referenced this pull request Mar 11, 2025
* Override `write_step` instead of `write_state`.

* Improve docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants