-
Notifications
You must be signed in to change notification settings - Fork 12
feat: parallel inference without slurm #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 3 3
Lines 51 51
=======================================
Hits 50 50
Misses 1 1 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
…oi-inference into feature/par-inf-without-slurm
HCookie
reviewed
Feb 6, 2025
HCookie
reviewed
Feb 12, 2025
HCookie
reviewed
Feb 12, 2025
gmertes
reviewed
Feb 13, 2025
for more information, see https://pre-commit.ci
…oi-inference into feature/par-inf-without-slurm
for more information, see https://pre-commit.ci
gmertes
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the Parallel Inference added in #55 to work without slurm within 1 node. It's much nicer to debug and run now :D
When running parallel inference without slurm, you have to add
world_size
to the config. At the moment, this is ignored in favour ofSLURM_NTASKS
when running with srun. An example of a config running parallel inference across 4 nodes is shown below. You can launch this job as normal withanemoi-inference run parinf.yaml
.How it works is:
config.world_size
processesmaster_addr
islocalhost
master_port
is a hash of the node name, within a range.RunCmd.run
but with the config preloadedIssues:
RunCmd.run
inrunners/parallel.py
. Would be nice to be able to use that code directly, rather then having to maintain a copy. To do this, I would just have to be able to pass a loaded config instead of a path📚 Documentation preview 📚: https://anemoi-inference--121.org.readthedocs.build/en/121/