Skip to content

Remove profiler (troubleshooting) functionality #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anaprietonem opened this issue Oct 8, 2024 · 1 comment
Open

Remove profiler (troubleshooting) functionality #22

anaprietonem opened this issue Oct 8, 2024 · 1 comment

Comments

@anaprietonem
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Currently in anemoi training we support 'two types' of profiling:

  1. Just for 'quick troubleshooting' - using profiler: True in the diagnostics config - profile the training code using the PytorchProfiler
  2. Using anemoiProfiler by running anemoi-training profiler.

The functionality of the first option is included already and even extended by the memory profiler of the AnemoiProfiler.
When setting the config for the anemoiProfiler it can be confusing if we also have a profiler flag.

Describe the solution you'd like

I would like to propose to remove the profiler flag and that section of the code. In terms of functionality, as mentioned above, we won't loose anything since that 'quick troubleshooting' could still be achieved running the anemoi-training profiler with just the memory report activated

Describe alternatives you've considered

No response

Additional context

No response

Organisation

No response

@anaprietonem anaprietonem added the enhancement New feature or request label Oct 8, 2024
@JesperDramsch JesperDramsch transferred this issue from ecmwf/anemoi-training Dec 19, 2024
@HCookie
Copy link
Member

HCookie commented Mar 12, 2025

This seems like a simple issue, @anaprietonem can you look at a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants