Remove print statements for logging (#421) (#439)

* first change

* removed all prints

* changed model.py back

* adding comments and fixes@

* added ruff fixes

* reverting files for PR

* ruff fixes

* removing run_id.py

* formatting changes

* changing comments in check_gh_issue script

---------

Co-authored-by: owens1 <[email protected]>
Co-authored-by: Timothy Hunter <[email protected]>

Author: 3 people

pyproject.toml

@@ -87,7 +87,9 @@ select = [
     # isort
     "I",
     # Banned imports
-    "TID"
+    "TID",
+    # print
+    "T201"
 ]
 
 # These rules are sensible and should be enabled at a later stage.

scripts/check_gh_issue.py

@@ -6,6 +6,8 @@
 # exclude-newer = "2025-01-01T00:00:00Z"
 # ///
 
+# ruff: noqa: T201
+
 """
 Checks that a pull request has a corresponding GitHub issue.
 

src/weathergen/model/model.py

@@ -1,3 +1,4 @@
+# ruff: noqa: T201
 # (C) Copyright 2025 WeatherGenerator contributors.
 
 #

src/weathergen/train/trainer.py

@@ -1,3 +1,5 @@
+# ruff: noqa: T201
+
 # (C) Copyright 2025 WeatherGenerator contributors.
 #
 # This software is licensed under the terms of the Apache Licence Version 2.0

src/weathergen/utils/compare_run_configs.py

@@ -8,10 +8,14 @@
 # nor does it submit to any jurisdiction.
 
 import argparse
+import logging
 
 import dictdiffer
 from obslearn.utils.config import Config
 
+_logger = logging.getLogger(__name__)
+
+
 if __name__ == "__main__":
     parser = argparse.ArgumentParser()
     parser.add_argument("-r1", "--run_id_1", required=True)
@@ -31,4 +35,4 @@
         #   name = cf1.streams[item[1][1]]['name']
         #   item[1][1] = name
 
-        print(f"{item[1]} :: {item[2]}")
+        _logger.info(f"Difference {item[1]} :: {item[2]}")

src/weathergen/utils/run_id.py

@@ -96,7 +96,6 @@ def write_stream_file(write_path, content: str):
 
 
 def get_expected_config(key, config):
-    print(key, config)
     config = OmegaConf.create(config)
     config.name = key
     return config