qa

Author: francesconazzaro

alembic/versions/a4e8be715296_add_deleted_as_new_status.py

@@ -5,9 +5,8 @@
 Create Date: 2024-07-25 13:13:11.955119
 
 """
-import sqlalchemy as sa
 
-from sqlalchemy.dialects.postgresql import ENUM
+import sqlalchemy as sa
 
 from alembic import op
 

cads_broker/dispatcher.py

@@ -342,7 +342,6 @@ def manage_dismissed_request(self, request, session):
             )
             request.status = "deleted"
         elif previous_status == "accepted":
-            print('-----------', dismission_metadata.get("reason", ""))
             self.queue.pop(request.request_uid, None)
             self.qos.notify_dismission_of_request(
                 request, session, scheduler=self.internal_scheduler

cads_broker/qos/QoS.py

@@ -143,9 +143,7 @@ def _properties(self, request, session):
                     database.set_dismissed_request(
                         request_uid=request.request_uid,
                         session=session,
-                        message=rule.info.evaluate(
-                            Context(request, self.environment)
-                        ),
+                        message=rule.info.evaluate(Context(request, self.environment)),
                         reason="PermissionError",
                     )
                     break
@@ -253,20 +251,24 @@ def user_limit(self, request):
 
         limits = self.per_user_limits.get(user, [])
         applied_limits = []
-        for limit in limits:
-            if limit.match(request):
-                applied_limits.append(limit)
+        for user_limit in limits:
+            if user_limit.match(request):
+                applied_limits.append(user_limit)
 
-        for limit in self.rules.user_limits:
-            if limit.match(request):
+        for user_limit in self.rules.user_limits:
+            if user_limit.match(request):
                 """
                 We clone the rule because we need one instance per different
                 user otherwise all users will share that limit
                 """
-                if limit.get_uid(request) not in [l.get_uid(request) for l in limits]:
-                    limit = limit.clone()
-                    applied_limits.append(limit)
-                    self.per_user_limits[user] = self.per_user_limits.get(user, []) + [limit]
+                if user_limit.get_uid(request) not in [
+                    limit.get_uid(request) for limit in limits
+                ]:
+                    user_limit = user_limit.clone()
+                    applied_limits.append(user_limit)
+                    self.per_user_limits[user] = self.per_user_limits.get(user, []) + [
+                        user_limit
+                    ]
         return applied_limits
 
     @locked