fix behaviour

Author: francesconazzaro

cads_broker/dispatcher.py

@@ -336,23 +336,21 @@ def manage_dismissed_request(self, request, session):
             session=session,
         )
         previous_status = dismission_metadata.get("previous_status", "accepted")
+        if dismission_metadata.get("reason", "DismissedRequest") == "PermissionError":
+            request.status = "failed"
+            request.finished_at = datetime.datetime.now()
+        else:
+            request.status = "deleted"
         if previous_status == "running":
             self.qos.notify_end_of_request(
                 request, session, scheduler=self.internal_scheduler
             )
-            request.status = "deleted"
         elif previous_status == "accepted":
             self.queue.pop(request.request_uid, None)
             self.qos.notify_dismission_of_request(
                 request, session, scheduler=self.internal_scheduler
             )
-            if (
-                reason := dismission_metadata.get("reason", "DismissedRequest")
-            ) == "DismissedRequest":
-                request.status = "deleted"
-            elif reason == "PermissionError":
-                request.status = "failed"
-                request.finished_at = datetime.datetime.now()
+        logger.info("job has finished", **db.logger_kwargs(request=request))
         return session
 
     @cachetools.cachedmethod(lambda self: self.ttl_cache)

cads_broker/entry_points.py

@@ -151,7 +151,7 @@ def delete_requests(
             status="dismissed",
             request_metadata={
                 "dismission": {
-                    "reason": "DismissedRequest",
+                    "reason": "PermissionError",
                     "message": message,
                     "previous_status": status,
                 }