Version 2.7.3

Fix v2.7.2

Author: eclipxe13

docs/CHANGELOG.md

@@ -13,6 +13,17 @@
 - Remove `trigger_error` on `\CfdiUtils\Elements\Cfdi33\Comprobante::getCfdiRelacionados` when called with arguments.
 
 
+## Version 2.7.3 2018-12-05
+
+- Fix previous release since it did not publish the changes made on 2.7.2.
+
+
+## Version 2.7.2 2018-12-05
+
+- Add method `CfdiUtils\Certificado\Certificado::getCertificateName(): string` to obtain the certificate
+  name as returned by `openssl_x509_parse`.
+
+
 ## Version 2.7.1 2018-12-04
 
 - Fix wrong use of `escapeshellcmd` replacing with `escapeshellarg`

docs/componentes/certificado.md

@@ -8,7 +8,8 @@ En este último caso es convertido internamente a formato PEM y luego interpreta
 Una vez cargado el certificado permite obtener los siguientes datos utilizando *getters* (como `getRfc()`):
 
 - RFC
-- Nombre
+- Nombre amigable
+- Nombre del certificado
 - Número de serie
 - Válido desde y hasta
 - Llave pública

src/CfdiUtils/Certificado/Certificado.php

@@ -6,6 +6,9 @@ class Certificado
     /** @var string */
     private $rfc;
 
+    /** @var string */
+    private $certificateName;
+
     /** @var string */
     private $name;
 
@@ -54,14 +57,17 @@ public function __construct(string $filename)
         if (! is_array($data)) {
             throw new \RuntimeException("Cannot parse the certificate file $filename");
         }
+        if (! isset($data['subject'])) {
+            $data['subject'] = [];
+        }
 
         // get the public key
         $pubKey = $this->obtainPubKeyFromContents($contents);
 
         // set all the values
-        $this->rfc = (string) strstr($data['subject']['x500UniqueIdentifier'] . ' ', ' ', true);
-        $this->rfc = (string) strstr($data['subject']['x500UniqueIdentifier'] . ' ', ' ', true);
-        $this->name = $data['subject']['name'];
+        $this->certificateName = strval($data['name'] ?? '');
+        $this->rfc = (string) strstr(($data['subject']['x500UniqueIdentifier'] ?? '') . ' ', ' ', true);
+        $this->name = strval($data['subject']['name'] ?? '');
         $serial = new SerialNumber('');
         if (isset($data['serialNumberHex'])) {
             $serial->loadHexadecimal($data['serialNumberHex']);
@@ -71,8 +77,8 @@ public function __construct(string $filename)
             throw new \RuntimeException("Cannot get serialNumberHex or serialNumber from certificate file $filename");
         }
         $this->serial = $serial->asAscii();
-        $this->validFrom = $data['validFrom_time_t'];
-        $this->validTo = $data['validTo_time_t'];
+        $this->validFrom = $data['validFrom_time_t'] ?? 0;
+        $this->validTo = $data['validTo_time_t'] ?? 0;
         $this->pubkey = $pubKey;
         $this->pemContents = $contents;
         $this->filename = $filename;
@@ -117,6 +123,11 @@ public function getRfc(): string
         return $this->rfc;
     }
 
+    public function getCertificateName(): string
+    {
+        return $this->certificateName;
+    }
+
     /**
      * Name (Razón Social) set when certificate was created
      * @return string

tests/CfdiUtilsTests/Certificado/CertificadoTest.php

@@ -28,6 +28,15 @@ public function testConstructWithValidExample()
         $certificado = new Certificado($cerfile);
 
         $this->assertEquals($cerfile, $certificado->getFilename());
+        $certificateName = implode('', [
+            '/CN=ACCEM SERVICIOS EMPRESARIALES SC',
+            '/name=ACCEM SERVICIOS EMPRESARIALES SC',
+            '/O=ACCEM SERVICIOS EMPRESARIALES SC',
+            '/x500UniqueIdentifier=AAA010101AAA / HEGT7610034S2',
+            '/serialNumber= / HEGT761003MDFRNN09',
+            '/OU=CSD01_AAA010101AAA',
+        ]);
+        $this->assertEquals($certificateName, $certificado->getCertificateName());
         $this->assertEquals('ACCEM SERVICIOS EMPRESARIALES SC', $certificado->getName());
         $this->assertEquals('AAA010101AAA', $certificado->getRfc());
         $this->assertEquals('30001000000300023708', $certificado->getSerial());