Version 2.12.6-1

Author: eclipxe13

.php_cs.dist

@@ -1,14 +1,19 @@
 <?php
+
+declare(strict_types=1);
+
 return PhpCsFixer\Config::create()
     ->setRiskyAllowed(true)
-    ->setCacheFile(__DIR__.'/build/.php_cs.cache')
+    ->setCacheFile(__DIR__ . '/build/.php_cs.cache')
     ->setRules([
         '@PSR2' => true,
-        'psr0' => false, // do not enforce psr-0, it rewrites 'namespace Test\' to 'namespace tests\'
+        '@PHP70Migration' => true,
+        // '@PHP70Migration:risky' => true,
         // symfony
+        'class_attributes_separation' => true,
         'whitespace_after_comma_in_array' => true,
         'no_empty_statement' => true,
-        'no_extra_consecutive_blank_lines' => true,
+        'no_extra_blank_lines' => true,
         'function_typehint_space' => true,
         'no_alias_functions' => true,
         'trailing_comma_in_multiline_array' => true,
@@ -18,23 +23,26 @@ return PhpCsFixer\Config::create()
         'object_operator_without_whitespace' => true,
         'binary_operator_spaces' => true,
         'phpdoc_scalar' => true,
+        'self_accessor' => true,
         'no_trailing_comma_in_singleline_array' => true,
         'single_quote' => true,
         'no_singleline_whitespace_before_semicolons' => true,
         'no_unused_imports' => true,
         'no_whitespace_in_blank_line' => true,
+        'yoda_style' => ['equal' => true, 'identical' => true, 'less_and_greater' => null],
+        'standardize_not_equals' => true,
         // contrib
         'concat_space' => ['spacing' => 'one'],
         'not_operator_with_successor_space' => true,
-        'no_blank_lines_before_namespace' => true,
+        'single_blank_line_before_namespace' => true,
         'linebreak_after_opening_tag' => true,
+        'blank_line_after_opening_tag' => true,
         'ordered_imports' => true,
         'array_syntax' => ['syntax' => 'short'],
     ])
     ->setFinder(
-        PhpCsFixer\Finder::create()->in([
-            __DIR__ . '/src',
-            __DIR__ . '/tests',
-        ])
+        PhpCsFixer\Finder::create()
+            ->in(__DIR__)
+            ->exclude(['vendor', 'build'])
     )
 ;

.travis.yml

@@ -30,6 +30,8 @@ env:
     global:
         - FULL_BUILD_PHP_VERSION="7.3"
         - COVERAGE_FILE=build/coverage-clover.xml
+        - PHP_CS_FIXER_FUTURE_MODE=1
+        - PHP_CS_FIXER_IGNORE_ENV=1
 
 before_script:
     - phpenv config-rm xdebug.ini || true

docs/CHANGELOG.md

@@ -7,6 +7,8 @@ theme:
 
 nav:
     - "CfdiUtils": "index.md"
+    - "Instalación":
+        - instalar/instalacion.md
     - "Lectura":
         - leer/leer-cfdi.md
         - leer/quickreader.md

docs/index.md

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 abstract class AbstractXsltBuilder implements XsltBuilderInterface

docs/instalar/instalacion.md

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 /**

mkdocs.yml

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 use CfdiUtils\CfdiVersion;

src/CfdiUtils/CadenaOrigen/AbstractXsltBuilder.php

@@ -1,9 +1,11 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 class CfdiDefaultLocations
 {
     const XSLT_32 = 'http://www.sat.gob.mx/sitio_internet/cfd/3/cadenaoriginal_3_2/cadenaoriginal_3_2.xslt';
+
     const XSLT_33 = 'http://www.sat.gob.mx/sitio_internet/cfd/3/cadenaoriginal_3_3/cadenaoriginal_3_3.xslt';
 
     public static function location(string $version): string

src/CfdiUtils/CadenaOrigen/CadenaOrigenBuilder.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 use DOMDocument;

src/CfdiUtils/CadenaOrigen/CadenaOrigenLocations.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 /**

src/CfdiUtils/CadenaOrigen/CfdiDefaultLocations.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 use DOMDocument;

src/CfdiUtils/CadenaOrigen/DOMBuilder.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 use CfdiUtils\Internals\ShellExec;

src/CfdiUtils/CadenaOrigen/DefaultLocations.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 class XsltBuildException extends \RuntimeException

src/CfdiUtils/CadenaOrigen/GenkgoXslBuilder.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 interface XsltBuilderInterface

src/CfdiUtils/CadenaOrigen/SaxonbCliBuilder.php

@@ -1,9 +1,12 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 interface XsltBuilderPropertyInterface
 {
     public function hasXsltBuilder(): bool;
+
     public function getXsltBuilder(): XsltBuilderInterface;
+
     public function setXsltBuilder(XsltBuilderInterface $xsltBuilder = null);
 }

src/CfdiUtils/CadenaOrigen/XsltBuildException.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\CadenaOrigen;
 
 trait XsltBuilderPropertyTrait

src/CfdiUtils/CadenaOrigen/XsltBuilderInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Certificado;
 
 use XmlResourceRetriever\AbstractBaseRetriever;

src/CfdiUtils/CadenaOrigen/XsltBuilderPropertyInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Certificado;
 
 use CfdiUtils\OpenSSL\OpenSSL;
@@ -101,7 +102,7 @@ private function extractPemCertificate(string $contents): string
         $decoded = @base64_decode($contents, true) ?: '';
         if ('' !== $decoded && $contents === base64_encode($decoded)) { // is a one liner certificate
             $doubleEncoded = $openssl->readPemContents($decoded)->certificate();
-            if ($doubleEncoded !== '') {
+            if ('' !== $doubleEncoded) {
                 return $doubleEncoded;
             }
             // derCerConvertPhp will include PEM header and footer

src/CfdiUtils/CadenaOrigen/XsltBuilderPropertyTrait.php

@@ -1,8 +1,10 @@
 <?php
+
 namespace CfdiUtils\Certificado;
 
 interface CertificadoPropertyInterface
 {
     public function getCertificado(): Certificado;
+
     public function setCertificado(Certificado $Certificado);
 }

src/CfdiUtils/Certificado/CerRetriever.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Certificado;
 
 trait CertificadoPropertyTrait

src/CfdiUtils/Certificado/Certificado.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Certificado;
 
 use CfdiUtils\Nodes\NodeInterface;

src/CfdiUtils/Certificado/CertificadoPropertyInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Certificado;
 
 class SatCertificateNumber

src/CfdiUtils/Certificado/CertificadoPropertyTrait.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Certificado;
 
 use CfdiUtils\Internals\BaseConverter;

src/CfdiUtils/Certificado/NodeCertificado.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils;
 
 use CfdiUtils\Nodes\NodeInterface;

src/CfdiUtils/Certificado/SatCertificateNumber.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils;
 
 use CfdiUtils\CadenaOrigen\DOMBuilder;

src/CfdiUtils/Certificado/SerialNumber.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils;
 
 use CfdiUtils\CadenaOrigen\DOMBuilder;

src/CfdiUtils/Cfdi.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils;
 
 use CfdiUtils\VersionDiscovery\StaticMethodsCompatTrait;

src/CfdiUtils/CfdiCreator33.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Cleaner;
 
 use CfdiUtils\Cfdi;

src/CfdiUtils/CfdiValidator33.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Cleaner;
 
 class CleanerException extends \RuntimeException

src/CfdiUtils/CfdiVersion.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\ConsultaCfdiSat;
 
 class Config

src/CfdiUtils/Cleaner/Cleaner.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\ConsultaCfdiSat;
 
 use CfdiUtils\Cfdi;

src/CfdiUtils/Cleaner/CleanerException.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\ConsultaCfdiSat;
 
 class StatusResponse

src/CfdiUtils/ConsultaCfdiSat/Config.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\ConsultaCfdiSat;
 
 use SoapClient;

src/CfdiUtils/ConsultaCfdiSat/RequestParameters.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Elements\Cce11;
 
 use CfdiUtils\Elements\Common\AbstractElement;

src/CfdiUtils/ConsultaCfdiSat/StatusResponse.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Elements\Cce11;
 
 use CfdiUtils\Elements\Common\AbstractElement;

src/CfdiUtils/ConsultaCfdiSat/WebService.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Elements\Cce11;
 
 use CfdiUtils\Elements\Common\AbstractElement;

src/CfdiUtils/Elements/Cce11/ComercioExterior.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Elements\Cce11;
 
 use CfdiUtils\Elements\Common\AbstractElement;

src/CfdiUtils/Elements/Cce11/DescripcionesEspecificas.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Elements\Cce11;
 
 use CfdiUtils\Elements\Cce11\Traits\DomicilioTrait;

src/CfdiUtils/Elements/Cce11/Destinatario.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Elements\Cce11;
 
 use CfdiUtils\Elements\Common\AbstractElement;

src/CfdiUtils/Elements/Cce11/Domicilio.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Elements\Cce11;
 
 use CfdiUtils\Elements\Common\AbstractElement;

src/CfdiUtils/Elements/Cce11/Emisor.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace CfdiUtils\Elements\Cce11;
 
 use CfdiUtils\Elements\Common\AbstractElement;