Version 2.1.0

- Fix `SumasConceptos` to work also with "ImpuestosLocales"
- Add elements helpers `CfdiUtils\Elements\ImpLocal10\ImpuestosLocales` to work with "ImpuestosLocales"
- Add `CfdiUtils\Certificado\CerRetriever` that works with `CfdiUtils\XmlResolver\XmlResolver` to download
  a certificate from the SAT repository
- Add a new validator `CfdiUtils\Validate\Cfdi33\Standard\TimbreFiscalDigitalSello` to validate that the SelloSAT
  is actually the signature of the Timbre Fiscal Digital. If not then the CFDI was modified
- Add a new real and valid CFDI to test, this allow `TimbreFiscalDigitalSello` to check real data and pass
- Update test with `cfdi33-valid.xml` to allow fail `TimbreFiscalDigitalSello`
- Travis: Remove xdebug for all but PHP 7.0

Author: eclipxe13

.travis.yml

@@ -11,8 +11,11 @@ php:
 sudo: false
 
 before_script:
-  - travis_retry composer self-update
   - travis_retry composer install --no-interaction --prefer-dist
+  - |
+    if [[ $TRAVIS_PHP_VERSION != '7.0' ]]; then
+        phpenv config-rm xdebug.ini
+    fi
 
 script:
   - mkdir -p build/tests/

README.md

@@ -20,6 +20,8 @@ Main features:
 - Create CFDI version 3.3 based on a friendly extendable non-xml objects (`nodes`)
 - Read CFDI version 3.2 and 3.3
 - Validate CFDI version 3.3 against schemas, cfdi signature (`Sello`) and custom rules
+- Validate that the Timbre Fiscal Digital signature match with the CFDI 3.3,
+  if not then the document was modified after signature. 
 - Helper objects to deal with:
     - `Cadena de origen` generation
     - Extract information from CER files or `Certificado` attribute

composer.json

@@ -17,7 +17,7 @@
     ],
     "require": {
         "php": ">=7.0",
-        "eclipxe/xmlresourceretriever": "^1.0",
+        "eclipxe/xmlresourceretriever": "^1.2",
         "eclipxe/xmlschemavalidator": "^2.0"
     },
     "require-dev": {

docs/CHANGELOG.md

@@ -1,3 +1,14 @@
+# Version 2.1.0 2018-01-17
+- Fix `SumasConceptos` to work also with "ImpuestosLocales"
+- Add elements helpers `CfdiUtils\Elements\ImpLocal10\ImpuestosLocales` to work with "ImpuestosLocales"
+- Add `CfdiUtils\Certificado\CerRetriever` that works with `CfdiUtils\XmlResolver\XmlResolver` to download
+  a certificate from the SAT repository
+- Add a new validator `CfdiUtils\Validate\Cfdi33\Standard\TimbreFiscalDigitalSello` to validate that the SelloSAT
+  is actually the signature of the Timbre Fiscal Digital. If not then the CFDI was modified
+- Add a new real and valid CFDI to test, this allow `TimbreFiscalDigitalSello` to check real data and pass
+- Update test with `cfdi33-valid.xml` to allow fail `TimbreFiscalDigitalSello`
+- Travis: Remove xdebug for all but PHP 7.0
+
 # Version 2.0.1 2018-01-03
 - Small bugfixes thanks to scrutinizer-ci.com
 - Fix some docblocks

docs/TODO.md

@@ -1,7 +1,10 @@
 # eclipxe/CfdiUtils To Do List
 
 - [ ] Create validation rules to detect errors on CFDI
+    - [X] Validate Matriz de errores del CFDI version 3.3
+    - [X] Validate SelloSAT at TimbreFiscalDigital
+    - [ ] Validate ComplementoComercioExterior
 - [ ] Add a pretty command line utility to validate cfdi files
-- [ ] Full code coverage on `CfdiUtils\Elements`
+- [X] Full code coverage on `CfdiUtils\Elements`
 - [ ] Implement catalogs published by SAT
     - Doubt: This catalogs may be on a database or hardcoded ?

src/CfdiUtils/Certificado/CerRetriever.php

@@ -0,0 +1,27 @@
+<?php
+namespace CfdiUtils\Certificado;
+
+use XmlResourceRetriever\AbstractBaseRetriever;
+use XmlResourceRetriever\RetrieverInterface;
+
+class CerRetriever extends AbstractBaseRetriever implements RetrieverInterface
+{
+    public function retrieve(string $resource): string
+    {
+        $this->clearHistory();
+        $localFilename = $this->download($resource);
+        $this->addToHistory($resource, $localFilename);
+        return $localFilename;
+    }
+
+    protected function checkIsValidDownloadedFile(string $source, string $localpath)
+    {
+        // check content is cer file
+        try {
+            new Certificado($localpath);
+        } catch (\Throwable $ex) {
+            unlink($localpath);
+            throw new \RuntimeException("The source $source is not a cer file", 0, $ex);
+        }
+    }
+}

src/CfdiUtils/Certificado/SatCertificateNumber.php

@@ -0,0 +1,39 @@
+<?php
+namespace CfdiUtils\Certificado;
+
+class SatCertificateNumber
+{
+    /** @var string */
+    private $id;
+
+    public function __construct(string $id)
+    {
+        if (! $this->isValidCertificateNumber($id)) {
+            throw new \UnexpectedValueException('The certificate number is not correct');
+        }
+        $this->id = $id;
+    }
+
+    public function number(): string
+    {
+        return $this->id;
+    }
+
+    public function remoteUrl(): string
+    {
+        return sprintf(
+            'https://rdc.sat.gob.mx/rccf/%s/%s/%s/%s/%s/%s.cer',
+            substr($this->id, 0, 6),
+            substr($this->id, 6, 6),
+            substr($this->id, 12, 2),
+            substr($this->id, 14, 2),
+            substr($this->id, 16, 2),
+            $this->id
+        );
+    }
+
+    public static function isValidCertificateNumber(string $id): bool
+    {
+        return (bool) preg_match('/^[0-9]{20}$/', $id);
+    }
+}

src/CfdiUtils/Elements/Cfdi33/Retenciones.php

@@ -12,9 +12,9 @@ public function getElementName(): string
 
     public function addRetencion(array $attributes = []): Retencion
     {
-        $Retencion = new Retencion($attributes);
-        $this->addChild($Retencion);
-        return $Retencion;
+        $retencion = new Retencion($attributes);
+        $this->addChild($retencion);
+        return $retencion;
     }
 
     public function multiRetencion(array ...$elementAttributes): self

src/CfdiUtils/Elements/ImpLocal10/ImpuestosLocales.php

@@ -0,0 +1,36 @@
+<?php
+namespace CfdiUtils\Elements\ImpLocal10;
+
+use CfdiUtils\Elements\Common\AbstractElement;
+
+class ImpuestosLocales extends AbstractElement
+{
+    public function addRetencionLocal(array $attributes = []): RetencionesLocales
+    {
+        $retencion = new RetencionesLocales($attributes);
+        $this->addChild($retencion);
+        return $retencion;
+    }
+
+    public function addTrasladoLocal(array $attributes = []): TrasladosLocales
+    {
+        $traslado = new TrasladosLocales($attributes);
+        $this->addChild($traslado);
+        return $traslado;
+    }
+
+    public function getElementName(): string
+    {
+        return 'implocal:ImpuestosLocales';
+    }
+
+    public function getFixedAttributes(): array
+    {
+        return [
+            'xmlns:implocal' => 'http://www.sat.gob.mx/implocal',
+            'xsi:schemaLocation' => 'http://www.sat.gob.mx/implocal'
+                . ' http://www.sat.gob.mx/sitio_internet/cfd/implocal/implocal.xsd',
+            'Version' => '1.0',
+        ];
+    }
+}

src/CfdiUtils/Elements/ImpLocal10/RetencionesLocales.php

@@ -0,0 +1,12 @@
+<?php
+namespace CfdiUtils\Elements\ImpLocal10;
+
+use CfdiUtils\Elements\Common\AbstractElement;
+
+class RetencionesLocales extends AbstractElement
+{
+    public function getElementName(): string
+    {
+        return 'implocal:RetencionesLocales';
+    }
+}

src/CfdiUtils/Elements/ImpLocal10/TrasladosLocales.php

@@ -0,0 +1,12 @@
+<?php
+namespace CfdiUtils\Elements\ImpLocal10;
+
+use CfdiUtils\Elements\Common\AbstractElement;
+
+class TrasladosLocales extends AbstractElement
+{
+    public function getElementName(): string
+    {
+        return 'implocal:TrasladosLocales';
+    }
+}

src/CfdiUtils/SumasConceptos/SumasConceptos.php

@@ -19,6 +19,14 @@ class SumasConceptos
     private $traslados = [];
     /** @var array */
     private $retenciones = [];
+    /** @var float */
+    private $localesImpuestosTrasladados;
+    /** @var float */
+    private $localesImpuestosRetenidos;
+    /** @var array */
+    private $localesTraslados = [];
+    /** @var array */
+    private $localesRetenciones = [];
     /** @var int */
     private $precision;
 
@@ -42,6 +50,12 @@ private function addComprobante(NodeInterface $comprobante)
         foreach ($conceptos as $concepto) {
             $this->addConcepto($concepto);
         }
+
+        $this->localesTraslados = $this->populateImpuestosLocales($comprobante, 'TrasladosLocales', 'Traslado');
+        $this->localesImpuestosTrasladados = array_sum(array_column($this->localesTraslados, 'Importe'));
+        $this->localesRetenciones = $this->populateImpuestosLocales($comprobante, 'RetencionesLocales', 'Retenido');
+        $this->localesImpuestosRetenidos = array_sum(array_column($this->localesRetenciones, 'Importe'));
+
         $this->traslados = $this->roundImpuestosGroup($this->traslados);
         $this->retenciones = $this->roundImpuestosGroup($this->retenciones);
         $this->impuestosTrasladados = (float) array_sum(array_column($this->traslados, 'Importe'));
@@ -52,7 +66,14 @@ private function addComprobante(NodeInterface $comprobante)
         $this->importes = round($this->importes, $this->precision);
         $this->descuento = round($this->descuento, $this->precision);
 
-        $this->total = $this->importes - $this->descuento + $this->impuestosTrasladados - $this->impuestosRetenidos;
+        $this->total = round(array_sum([
+            $this->importes,
+            - $this->descuento,
+            $this->impuestosTrasladados,
+            - $this->impuestosRetenidos,
+            $this->localesImpuestosTrasladados,
+            - $this->localesImpuestosRetenidos,
+        ]), $this->precision);
     }
 
     private function addConcepto(NodeInterface $concepto)
@@ -71,6 +92,20 @@ private function addConcepto(NodeInterface $concepto)
         }
     }
 
+    private function populateImpuestosLocales(NodeInterface $comprobante, string $plural, string $singular): array
+    {
+        $locales = $comprobante->searchNodes('cfdi:Complemento', 'implocal:ImpuestosLocales', 'implocal:' . $plural);
+        $list = [];
+        foreach ($locales as $local) {
+            $list[] = [
+                'Impuesto' => $local['ImpLoc' . $singular],
+                'Tasa' => (float) $local['Tasade' . $singular],
+                'Importe' => (float) $local['Importe'],
+            ];
+        }
+        return $list;
+    }
+
     private function roundImpuestosGroup(array $group): array
     {
         foreach (array_keys($group) as $key) {
@@ -167,4 +202,34 @@ public function getPrecision(): int
     {
         return $this->precision;
     }
+
+    public function getLocalesImpuestosTrasladados(): float
+    {
+        return $this->localesImpuestosTrasladados;
+    }
+
+    public function getLocalesImpuestosRetenidos(): float
+    {
+        return $this->localesImpuestosRetenidos;
+    }
+
+    public function getLocalesTraslados(): array
+    {
+        return $this->localesTraslados;
+    }
+
+    public function getLocalesRetenciones(): array
+    {
+        return $this->localesRetenciones;
+    }
+
+    public function hasLocalesTraslados(): bool
+    {
+        return (count($this->localesTraslados) > 0);
+    }
+
+    public function hasLocalesRetenciones(): bool
+    {
+        return (count($this->localesRetenciones) > 0);
+    }
 }

src/CfdiUtils/Validate/Assert.php

@@ -19,7 +19,7 @@ class Assert
      * Assert constructor.
      * @param string $code
      * @param string $title
-     * @param Status $status
+     * @param Status|null $status If null the status will be NONE
      * @param string $explanation
      */
     public function __construct(string $code, string $title = '', Status $status = null, string $explanation = '')