Avoid retrieving AST root during diagnostic publishing.

[snjeza]

A related issue - redhat-developer/vscode-java#2982

Steps to reproduce

$ rm -rf jhisper-lite
$ git clone https://github.com/snjeza/jhipster-lite
$ cd jhipster-lite
$ code .

• enable lombok
• open AssertTest.java

private void test() {
    D d = new D| // try CA here
   // type
  Model56 model56 = new Model56();
  model56.getWeight()

  }

• check line Validated X. Took XXX ms

Test vsix 1.17.3

[rgrunber]

I can confirm the the vsix reduces the time to publish diagnostics from a few seconds to a few hundred ms with the vsix. However, this doesn't happn when I build and run against the PR. I even tried with the exact same settings. I think the change is fine to merge, but why the difference ?

Update: Also please rename the commit title to something like Avoid retrieving AST root during diagnostic publishing.

[snjeza]

Update: Also please rename the commit title to something like Avoid retrieving AST root during diagnostic publishing.

Fixed

[snjeza]

However, this doesn't happn when I build and run against the PR. I even tried with the exact same settings.

17.1.3 vsix also includes #2535

[rgrunber]

I think I was rebasing your patch to be on top of the latest commit. Even now I'm seeing validation take a few seconds whereas with your vsix it's a few hundred ms.

Update: I'll merge, but it would be good to verify why I'm seeing this.

[snjeza]

Update: I'll merge, but it would be good to verify why I'm seeing this.
... with your vsix it's a few hundred ms.

Did you enabled lombok?