Skip to content

Add quickfix for accessing non visible references #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fbricon opened this issue Nov 17, 2017 · 1 comment
Closed

Add quickfix for accessing non visible references #446

fbricon opened this issue Nov 17, 2017 · 1 comment
Assignees
@yaohaizh
Labels
code-actions enhancement
Milestone
Mid June 2018

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 17, 2017 •
edited
Loading

Handle the following cases in QuickFixProcessor:

case IProblem.NotVisibleField:
    GetterSetterCorrectionSubProcessor.addGetterSetterProposal(context,problem, proposals,
        IProposalRelevance.GETTER_SETTER_NOT_VISIBLE_FIELD);
    ModifierCorrectionSubProcessor.addNonAccessibleReferenceProposal(context,problem, proposals, 
        ModifierCorrectionSubProcessor.TO_VISIBLE,IProposalRelevance.CHANGE_VISIBILITY);
case IProblem.NotVisibleMethod:
case IProblem.NotVisibleConstructor:
case IProblem.NotVisibleType:
case IProblem.JavadocNotVisibleType:
    ModifierCorrectionSubProcessor.addNonAccessibleReferenceProposal(context,problem, proposals, 
       ModifierCorrectionSubProcessor.TO_VISIBLE, IProposalRelevance.CHANGE_VISIBILITY);
@fbricon fbricon changed the title Add quickfix for adding getters/setters to non visible fields Add quickfix for accessing non visible references Nov 17, 2017
@yaohaizh yaohaizh self-assigned this Apr 11, 2018
@fbricon fbricon added this to the End April 2018 milestone Apr 19, 2018
@fbricon fbricon modified the milestones: End April 2018, Mid May 2018 Apr 26, 2018
@tsmaeder tsmaeder mentioned this issue May 7, 2018
Closed
15 tasks
@fbricon fbricon modified the milestones: Mid May 2018, End May 2018 May 15, 2018
@tsmaeder tsmaeder mentioned this issue May 24, 2018
Closed
22 tasks
@fbricon fbricon modified the milestones: End May 2018, Mid June 2018 May 31, 2018
@fbricon
Copy link
Contributor Author

fbricon commented Jun 4, 2018

Fixed with #679

@fbricon fbricon closed this as completed Jun 4, 2018
@tsmaeder tsmaeder mentioned this issue Jun 18, 2018
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaohaizh yaohaizh

Labels
code-actions enhancement
Projects
None yet
Milestone
Mid June 2018
Development

No branches or pull requests
2 participants
@fbricon @yaohaizh