Fix bug in keyexpr::includes leading to call get_unchecked on empty array UB (#1208)

OlivierHecart · web-flow · commit 869ace655e7b · 2024-07-02T11:09:09.000+02:00
diff --git a/commons/zenoh-keyexpr/src/key_expr/include.rs b/commons/zenoh-keyexpr/src/key_expr/include.rs
@@ -41,7 +41,7 @@ impl Includer<&[u8], &[u8]> for LTRIncluder {
                 if (lempty && !right.has_verbatim()) || (!lempty && self.includes(lrest, right)) {
                     return true;
                 }
-                if unsafe { right.has_direct_verbatim_non_empty() } {
+                if right.has_direct_verbatim() {
                     return false;
                 }
                 right = Split::split_once(right, &DELIMITER).1;

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ impl Includer<&[u8], &[u8]> for LTRIncluder {`
`41`	`41`	`if (lempty && !right.has_verbatim()) \|\| (!lempty && self.includes(lrest, right)) {`
`42`	`42`	`return true;`
`43`	`43`	`}`
`44`		`- if unsafe { right.has_direct_verbatim_non_empty() } {`
	`44`	`+ if right.has_direct_verbatim() {`
`45`	`45`	`return false;`
`46`	`46`	`}`
`47`	`47`	`right = Split::split_once(right, &DELIMITER).1;`