Skip to content

Commit d0b180c

Browse files
lucas-koehlersgraband
authored andcommitted
Remove webview wildcard from default values
The webview wildcard configuration breaks default deployments because it requires additional configuration to generate/use wildcard certificates. This is not supported by Let's encrypt out of the box. Thus, remove the webview wildcard configuration from the default values.
1 parent 07d6dc2 commit d0b180c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

charts/theia-cloud/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type: application
1515
# This is the chart version. This version number should be incremented each time you make changes
1616
# to the chart and its templates, including the app version.
1717
# Versions are expected to follow Semantic Versioning (https://semver.org/)
18-
version: 0.12.0-next.1
18+
version: 0.12.0-next.2
1919

2020
# This is the version number of the application being deployed. This version number should be
2121
# incremented each time you make changes to the application. Versions are not expected to

charts/theia-cloud/values.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@ hosts:
8484
# IMPORTANT: If this gets updated, the helm chart needs to be re-installed because
8585
# helm upgrade will not properly update this at the moment.
8686
# These are required to configure TLS (if enabled via ingress.tls == true)
87-
allWildcardInstances: ["*.webview."]
87+
# I.e. custom certificates or a cert-manager provider that can handle wildcard certificates need to be configured.
88+
allWildcardInstances: []
8889

8990
# -- Values related to the landing page
9091
# @default -- (see details below)

0 commit comments

Comments
 (0)