Skip to content

Commit a0c979f

Browse files
committed
Bug #392: Map appropriate debug fields to Integer instead of Long
The initial implementation of lsp4j.debug used Long to map JSON's integer values as the debug protocol spec did not provide range information. See also microsoft/debug-adapter-protocol#90
1 parent 5ad981b commit a0c979f

File tree

58 files changed

+402
-413
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+402
-413
lines changed

CHANGELOG.md

+3-14
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,9 @@
88
Fixed issues: https://github.com/eclipse/lsp4j/milestone/15?closed=1
99

1010
Breaking API changes:
11-
* In DebugProtocol many fields which used to be defined as `Long` are now `Integer`.
12-
This is due to changes in DAP 1.36 that clarified these values should be less
13-
than or equal to 2147483647 (2^31 - 1)
14-
- `OutputEventArguments`: `variablesReference`
15-
- `RunInTerminalResponse`: `processId`, `shellProcessId`
16-
- `DataBreakpointInfoArguments`: `variablesReference`
17-
- `VariablesArguments`: `variablesReference`
18-
- `SetVariableResponse`: `variablesReference`, `namedVariables`, `indexedVariables`
19-
- `SetVariableArguments`: `variablesReference`
20-
- `EvaluateResponse`: `variablesReference`, `namedVariables`, `indexedVariables`
21-
- `SetExpressionResponse`: `variablesReference`, `namedVariables`, `indexedVariables`
22-
- `Source`: `sourceReference`
23-
- `Scope`: `variablesReference`, `namedVariables`, `indexedVariables`
24-
- `Variable`: `variablesReference`, `namedVariables`, `indexedVariables`
11+
* In DebugProtocol fields which used to be defined as `Long` are now `Integer`.
12+
This is due to changes in DAP 1.36 and clarification sought from
13+
https://github.com/microsoft/debug-adapter-protocol/issues/90
2514

2615
* The DebugProtocol's `EvaluateResponse`'s field `memoryReference` was previously incorrectly
2716
declared as `Long`, it is now correctly declared as `String`

0 commit comments

Comments
 (0)