Skip to content

Issue: Two Quickstarts are similarly named in JKube Website #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Urjaswi-2655 opened this issue Mar 25, 2022 · 5 comments · Fixed by #1401
Closed

Issue: Two Quickstarts are similarly named in JKube Website #1400

Urjaswi-2655 opened this issue Mar 25, 2022 · 5 comments · Fixed by #1401
Assignees
Milestone

Comments

@Urjaswi-2655
Copy link
Contributor

Both Quickstarts are named the same JKube Website here i.e Maven:: Wildfly JAR but one is Wildfly JAR and the Other one is Wildfly JAR Slim.
Screenshot (1658)
But As Per naming Convention one should be Maven :: Wildfly JAR and Other one should be Maven :: Wildfly JAR :: Slim
Naming Convention is predicted with respect to Maven :: Webapp :: Wildfly and Maven :: Webapp :: Wildfly :: Datasource
Screenshot (1661)

@Urjaswi-2655 Urjaswi-2655 changed the title Issue: Two Quickstarts are similarly named in [JKube Website](https://www.eclipse.org/jkube/quickstarts/) here. Issue: Two Quickstarts are similarly named in JKube Website Mar 25, 2022
@Urjaswi-2655
Copy link
Contributor Author

@rohanKanojia I would like to work on this issue and one on the eclipse/jkube#1394

@Urjaswi-2655
Copy link
Contributor Author

Urjaswi-2655 commented Mar 25, 2022

@manusa @rohanKanojia Created PR 33 && 34

for issue #1394 here

@Urjaswi-2655
Copy link
Contributor Author

Urjaswi-2655 commented Mar 26, 2022

@manusa @rohanKanojia Created PR for this issue #1401 here

@manusa
Copy link
Member

manusa commented Mar 28, 2022

@manusa @rohanKanojia Created PR for this issue #1401 here

Hi @Urjaswi-2655, When you create a PR the recommended approach is to add a meaningful description of what it does, and in other pointer that might help reviewers.

In this case, something like Fix #1400, updated WildFly Jar Slim quickstart's name to make it more specific and avoid a duplicity with the regular WildFly Jar quickstart would be much better and would allow you to skip redundantly commenting your tasks.

@manusa manusa mentioned this issue Mar 28, 2022
12 tasks
@Urjaswi-2655
Copy link
Contributor Author

@manusa @rohanKanojia Created PR for this issue #1401 here

Hi @Urjaswi-2655, When you create a PR the recommended approach is to add a meaningful description of what it does, and in other pointer that might help reviewers.

In this case, something like Fix #1400, updated WildFly Jar Slim quickstart's name to make it more specific and avoid a duplicity with the regular WildFly Jar quickstart would be much better and would allow you to skip redundantly commenting your tasks.

Sorry , it was my first PR . Will not repeat this mistake again . Thanks @manusa

@manusa manusa added this to the 1.8.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants