-
Notifications
You must be signed in to change notification settings - Fork 547
Issue: Two Quickstarts are similarly named in JKube Website #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@rohanKanojia I would like to work on this issue and one on the eclipse/jkube#1394 |
@manusa @rohanKanojia Created PR for this issue #1401 here |
Hi @Urjaswi-2655, When you create a PR the recommended approach is to add a meaningful description of what it does, and in other pointer that might help reviewers. In this case, something like |
Sorry , it was my first PR . Will not repeat this mistake again . Thanks @manusa |
Both Quickstarts are named the same JKube Website here i.e Maven:: Wildfly JAR but one is Wildfly JAR and the Other one is Wildfly JAR Slim.


But As Per naming Convention one should be
Maven :: Wildfly JAR
and Other one should beMaven :: Wildfly JAR :: Slim
Naming Convention is predicted with respect to
Maven :: Webapp :: Wildfly
andMaven :: Webapp :: Wildfly :: Datasource
The text was updated successfully, but these errors were encountered: