Skip to content

Failed to compile v1.43.0 version using jdk17 on Windows system #3427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eternity-LG opened this issue Mar 30, 2025 · 7 comments
Open

Failed to compile v1.43.0 version using jdk17 on Windows system #3427

Eternity-LG opened this issue Mar 30, 2025 · 7 comments

Comments

@Eternity-LG
Copy link

Image
@Eternity-LG
Copy link
Author

I want to know how to solve compilation failures. Here is my local environment information:

Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: D:\AppDevelopment\apache-maven-3.9.9
Java version: 17.0.14, vendor: Oracle Corporation, runtime: D:\AppDevelopment\jdk-17.0.14
Default locale: zh_CN, platform encoding: GBK
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

@Eternity-LG
Copy link
Author

MVN always compiles from https://ci.eclipse.org/ls/job/jdt-core-incubator/job/dom-with-javac/lastSuccessfulBuild/artifact/repository/target/repository/plugins/ Download dependency, the latest org. eclipse. jdt. core. javac_1.0.0. z20250328-1732.jar requires JavaSE-24, so compiling with the v1.43.0 tag source code has been failing

@rgrunber
Copy link
Contributor

rgrunber commented Apr 1, 2025

I would try using JDK 23 to compile. It's basically what the builds currently use and you need at least a Java 21 runtime to launch the server. I do have a JDK 24 on my system so maybe that's enough to silence the org.eclipse.jdt.core.javac bundle errors.

@Eternity-LG
Copy link
Author

Okay, thank you for your help. If I want to compile and start services using the JDK 17 environment, which tag code is more suitable? I can only rely on the README document in the Git repository to choose which tag's code.

@Eternity-LG
Copy link
Author

Image

@rgrunber
Copy link
Contributor

rgrunber commented Apr 1, 2025

Ah right, I see the issue. You're basically trying to rebuild the v1.43.0 tag right ? For a second I thought you were on the main branch due to the URL. Many of our target platform links, from https://github.com/eclipse-jdtls/eclipse.jdt.ls/blob/main/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target are static links that always get the latest content. This makes rebuilding difficult because the content isn't frozen. There is a solution though.

ALl you need to do is follow the instructions from #3001 (comment) . Just replace the URL being added with https://download.eclipse.org/jdtls/milestones/1.43.0/repository/ . This should get the project bulding and you may need to modify the product module a bit since it looks like the javac bundle isn't included (but it's not really needed if you only plan to compile with ECJ, the standard approach for now)

@Eternity-LG
Copy link
Author

Okay, I'll give it a try. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants