java.diagnostic.filter is broken on Windows

[Kamii0909]

[Error - 1:09:17 PM] Sep 27, 2024, 1:09:17 PM An internal error occurred during: "Publish Diagnostics".
Illegal char <:> at index 2: /D:/jdtls/src/App.java
java.nio.file.InvalidPathException: Illegal char <:> at index 2: /D:/jdtls/src/App.java
	at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:204)
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:175)
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
	at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
	at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:231)
	at java.base/java.nio.file.Path.of(Path.java:148)
	at java.base/java.nio.file.Paths.get(Paths.java:69)
	at org.eclipse.jdt.ls.core.internal.JDTUtils.isExcludedFile(JDTUtils.java:1871)
	at org.eclipse.jdt.ls.core.internal.handlers.BaseDiagnosticsHandler.matchesDiagnosticFilter(BaseDiagnosticsHandler.java:154)
	at org.eclipse.jdt.ls.core.internal.handlers.BaseDiagnosticsHandler.endReporting(BaseDiagnosticsHandler.java:138)
	at org.eclipse.jdt.internal.core.ReconcileWorkingCopyOperation.reportProblems(ReconcileWorkingCopyOperation.java:141)
	at org.eclipse.jdt.internal.core.ReconcileWorkingCopyOperation.executeOperation(ReconcileWorkingCopyOperation.java:110)
	at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:739)
	at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:804)
	at org.eclipse.jdt.internal.core.CompilationUnit.reconcile(CompilationUnit.java:1303)
	at org.eclipse.jdt.ls.core.internal.handlers.BaseDocumentLifeCycleHandler.publishDiagnostics(BaseDocumentLifeCycleHandler.java:332)
	at org.eclipse.jdt.ls.core.internal.handlers.BaseDocumentLifeCycleHandler.publishDiagnostics(BaseDocumentLifeCycleHandler.java:295)
	at org.eclipse.jdt.ls.core.internal.handlers.BaseDocumentLifeCycleHandler$PublishDiagnosticJob.run(BaseDocumentLifeCycleHandler.java:777)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

This is due to improper path handling in JDTUtils. Applying the following patch (sort of) works:

diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java
index 79af9970..d609a397 100644
--- a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java
+++ b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java
@@ -25,6 +25,7 @@ import java.net.URISyntaxException;
 import java.nio.file.FileSystem;
 import java.nio.file.Files;
 import java.nio.file.Paths;
+import java.nio.file.InvalidPathException;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Iterator;
@@ -1869,7 +1870,7 @@ public final class JDTUtils {
 		java.nio.file.Path[] path = new java.nio.file.Path[1];
 		try {
 			path[0] = Paths.get(uri.toURL().getPath());
-		} catch (MalformedURLException e) {
+		} catch (MalformedURLException | InvalidPathException e) {
 			path[0] = Paths.get(uri);
 		}
 		FileSystem fileSystems = path[0].getFileSystem();

And due to escaping, java.diagnostic.filter must be set to something like **\\\\src\\\\Foo.java. Technically, it is also possible to manually convert from Unix path to Windows path to support the the same configuration on both platform.

[rgrunber]

I'm able to reproduce. It prevents the language server from starting (when java.diagnostic.filter is used on Windows). Might be related to https://github.com/eclipse-jdtls/eclipse.jdt.ls/pull/3235/files#diff-38af31aa96ae8ee1debae74bf388b43dea8891646b1032ecdb2f4a7ea3e06f8cR1871 , which fixed some encoding issues on Linux.

There should be a way to get a path from the uri without it failing.

[snjeza]

And due to escaping, java.diagnostic.filter must be set to something like **\\src\\Foo.java. Technically, it is also possible to manually convert from Unix path to Windows path to support the the same configuration on both platform.

I have tried the following pattern on Windows:

"java.diagnostic.filter": [
        "**/src/main/java/**/HelloWorld.java"
 ],   

It works fine with the PR.