-
Notifications
You must be signed in to change notification settings - Fork 417
Add support for callees based on implementors #2780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is there a concrete example of this ? Is there a case where an interface method ends up in the call hierarchy ? If I just perform call hierarchy on an interface method, I see the implementors are already used. |
I will provide a sample scenario |
Now try to create outgoing call tree on |
Is there any reason this wasn't enabled by default in Eclipse ? I think it's reasonable to set this. So if an outgoing call is done through an interface, where there's only 1 implementation, the call hierarchy should follow the single implementor and make it the child of the given element. The one downside is the hierarchy is "techically" not correct. The 2 get methods should be replaced by just the |
I think we added that in Eclipse so that if users find it heavy when generating the hierarchy for certain workspaces, then they can opt out of that feature. We can do the same in vscode as well by introducing the setting as we did for chain completions isn't it ?
Isn't it gaining to make it unclear for a user who is discovering that hierarchy for the first time in the code base ?
Even if we find only one implementation, should we make this decision that the |
Add support for the following feature which exist in Eclipse IDE into JDT.LS as well.
eclipse-jdt/eclipse.jdt.ui@5f69112
Summary:
When the call hierarchy finds a interface, this feature will try to find implementations and then continue on with the implementation methods to show the callees.
The text was updated successfully, but these errors were encountered: