Skip to content

Commit eb8f148

Browse files
committed
Renaming the methods arguments
Signed-off-by: sheche <[email protected]>
1 parent c26d07a commit eb8f148

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/ProjectConfigurationUpdateHandler.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,15 @@ public ProjectConfigurationUpdateHandler(ProjectsManager projectManager) {
3838
this.projectManager = projectManager;
3939
}
4040

41-
public void updateConfigurations(List<TextDocumentIdentifier> param) {
41+
/**
42+
* Update the projects' configurations (build files).
43+
*
44+
* @param identifiers the identifiers which may point to the projects' paths or
45+
* files that belong to some projects in the workspace.
46+
*/
47+
public void updateConfigurations(List<TextDocumentIdentifier> identifiers) {
4248
Set<IProject> projects = new HashSet<>();
43-
for (TextDocumentIdentifier identifier : param) {
49+
for (TextDocumentIdentifier identifier : identifiers) {
4450
IProject project = getProjectFromUri(identifier.getUri());
4551
if (project != null) {
4652
projects.add(project);

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/lsp/JavaProtocolExtensions.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ public interface JavaProtocolExtensions {
6262

6363
/**
6464
* Request a project configuration update
65+
*
66+
* @deprecated Please use {@link #projectConfigurationsUpdate(TextDocumentIdentifier)}.
6567
* @param documentUri the document from which the project configuration will be updated
6668
*/
6769
@JsonNotification
@@ -72,7 +74,7 @@ public interface JavaProtocolExtensions {
7274
* @param documentUris the documents from which the project configuration will be updated
7375
*/
7476
@JsonNotification
75-
void projectConfigurationsUpdate(ProjectConfigurationsUpdateParam documentUris);
77+
void projectConfigurationsUpdate(ProjectConfigurationsUpdateParam params);
7678

7779
@JsonRequest
7880
CompletableFuture<BuildWorkspaceStatus> buildWorkspace(Either<Boolean, boolean[]> forceReBuild);

org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/ProjectConfigurationUpdateHandlerTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import static org.mockito.ArgumentMatchers.any;
1717
import static org.mockito.ArgumentMatchers.anyBoolean;
1818
import static org.mockito.ArgumentMatchers.eq;
19-
import static org.mockito.Mockito.doNothing;
2019
import static org.mockito.Mockito.mock;
2120
import static org.mockito.Mockito.times;
2221
import static org.mockito.Mockito.verify;

0 commit comments

Comments
 (0)