Read the server logs in order to discover early startup log messages.

- Attach a platform log listener sooner (in bundle activation)
- Cache status messages that arrive before client connection set up
- Send cached / server log messages once client is connected

Signed-off-by: Roland Grunberg <[email protected]>

Author: rgrunber

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JavaClientConnection.java

@@ -20,7 +20,6 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 
-import org.eclipse.jdt.ls.core.internal.handlers.LogHandler;
 import org.eclipse.jdt.ls.core.internal.lsp.ExecuteCommandProposedClient;
 import org.eclipse.lsp4j.ApplyWorkspaceEditParams;
 import org.eclipse.lsp4j.ApplyWorkspaceEditResponse;
@@ -76,13 +75,10 @@ public interface JavaLanguageClient extends LanguageClient, ExecuteCommandPropos
 
 	}
 
-	private final LogHandler logHandler;
 	final JavaLanguageClient client;
 
 	public JavaClientConnection(JavaLanguageClient client) {
 		this.client = client;
-		logHandler = new LogHandler();
-		logHandler.install(this);
 	}
 
 	public Object executeClientCommand(Duration timeout, String id, Object... params) throws InterruptedException, ExecutionException, TimeoutException {
@@ -217,12 +213,6 @@ public CompletableFuture<Void> refreshInlayHints() {
 		return this.client.refreshInlayHints();
 	}
 
-	public void disconnect() {
-		if (logHandler != null) {
-			logHandler.uninstall();
-		}
-	}
-
 	public void telemetryEvent(Object object) {
 		if (JavaLanguageServerPlugin.getPreferencesManager() != null
 			&& JavaLanguageServerPlugin.getPreferencesManager().getPreferences().isTelemetryEnabled()) {

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JavaLanguageServerPlugin.java

@@ -51,6 +51,7 @@
 import org.eclipse.jdt.ls.core.internal.corext.template.java.JavaLanguageServerTemplateStore;
 import org.eclipse.jdt.ls.core.internal.handlers.CompletionContributionService;
 import org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer;
+import org.eclipse.jdt.ls.core.internal.handlers.LogHandler;
 import org.eclipse.jdt.ls.core.internal.managers.ContentProviderManager;
 import org.eclipse.jdt.ls.core.internal.managers.DigestStore;
 import org.eclipse.jdt.ls.core.internal.managers.ISourceDownloader;
@@ -127,6 +128,7 @@ public class JavaLanguageServerPlugin extends Plugin {
 
 	private ExecutorService executorService;
 	private CompletionContributionService completionContributionService;
+	private LogHandler logHandler;
 
 	public static LanguageServerApplication getLanguageServer() {
 		return pluginInstance == null ? null : pluginInstance.languageServer;
@@ -147,6 +149,9 @@ public void start(BundleContext bundleContext) throws Exception {
 		JavaLanguageServerPlugin.pluginInstance = this;
 		setPreferenceNodeId();
 
+		logHandler = new LogHandler();
+		logHandler.install();
+
 		if (JDTEnvironmentUtils.isSyntaxServer()) {
 			disableServices();
 			preferenceManager = new PreferenceManager();
@@ -353,6 +358,7 @@ private void startConnection() throws IOException {
 		}
 		protocol.connectClient(launcher.getRemoteProxy());
 		launcher.startListening();
+		logHandler.setClientConnection(pluginInstance.getClientConnection());
 	}
 
 	/*

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/LanguageServerApplication.java

@@ -58,7 +58,7 @@ public Object start(IApplicationContext context) throws Exception {
 				// Setting progressProvider is only allowed if the application is "owned" by the caller.
 				// see Javadoc for setProgressProvider.
 				// In case of JDT-LS integrated in Eclipse Workbench, the application is the workbench and this progressProvider
-				// must not be overridden. In case of the LanguageServerApplication, we own it, so we can set. 
+				// must not be overridden. In case of the LanguageServerApplication, we own it, so we can set.
 				Job.getJobManager().setProgressProvider(progressReporterManager);
 			}
 		}