Move the error marker check to ResourceUtils as helper method

Author: testforstephen

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ResourceUtils.java

@@ -44,6 +44,7 @@
 import org.eclipse.core.runtime.Platform;
 import org.eclipse.core.runtime.URIUtil;
 import org.eclipse.jdt.core.IJavaModelMarker;
+import org.eclipse.jdt.core.compiler.IProblem;
 
 import com.google.common.base.Charsets;
 import com.google.common.io.CharStreams;
@@ -383,4 +384,9 @@ public static IMarker createWarningMarker(String type, IResource resource, Strin
 		marker.setAttribute(IMarker.SEVERITY, IMarker.SEVERITY_WARNING);
 		return marker;
 	}
+
+	public static boolean isUnresolvedImportError(IMarker marker) {
+		return marker.getAttribute(IMarker.SEVERITY, 0) == IMarker.SEVERITY_ERROR
+			&& marker.getAttribute(IJavaModelMarker.ID, 0) == IProblem.ImportNotFound;
+	}
 }

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/TelemetryManager.java

@@ -28,14 +28,13 @@
 import org.eclipse.core.resources.IResource;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IPath;
-import org.eclipse.jdt.core.IJavaModelMarker;
 import org.eclipse.jdt.core.IJavaProject;
 import org.eclipse.jdt.core.IPackageFragmentRoot;
-import org.eclipse.jdt.core.compiler.IProblem;
 import org.eclipse.jdt.launching.IVMInstall;
 import org.eclipse.jdt.launching.JavaRuntime;
 import org.eclipse.jdt.ls.core.internal.JavaClientConnection.JavaLanguageClient;
 import org.eclipse.jdt.ls.core.internal.ProjectUtils;
+import org.eclipse.jdt.ls.core.internal.ResourceUtils;
 import org.eclipse.jdt.ls.core.internal.preferences.PreferenceManager;
 
 import com.google.gson.JsonArray;
@@ -119,7 +118,7 @@ public void onBuildFinished(long buildFinishedTime) {
 					IMarker[] projectMarkers = project.findMarkers(null /* all markers */, true /* subtypes */, IResource.DEPTH_ZERO);
 					projectErrors += Stream.of(projectMarkers).filter(m -> m.getAttribute(IMarker.SEVERITY, 0) == IMarker.SEVERITY_ERROR).count();
 					IMarker[] allmarkers = project.findMarkers(null /* all markers */, true /* subtypes */, IResource.DEPTH_INFINITE);
-					unresolvedImportErrors += Stream.of(allmarkers).filter(m -> isUnresolvedImportError(m)).count();
+					unresolvedImportErrors += Stream.of(allmarkers).filter(m -> ResourceUtils.isUnresolvedImportError(m)).count();
 				} catch (CoreException e) {
 					// ignore
 				}
@@ -171,11 +170,6 @@ public void onBuildFinished(long buildFinishedTime) {
 		telemetryEvent(JAVA_PROJECT_BUILD, properties);
 	}
 
-	private boolean isUnresolvedImportError(IMarker marker) {
-		return marker.getAttribute(IMarker.SEVERITY, 0) == IMarker.SEVERITY_ERROR
-			&& marker.getAttribute(IJavaModelMarker.ID, 0) == IProblem.ImportNotFound;
-	}
-
 	/**
 	 * The total size (in bytes) of all dependencies in the workspace
 	 * This should correspond to the total size of dependencies used by a