Skip to content

JavacTypeBinding.resolved(IType type) creating ResolvedSourceType with bad unique key #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robstryker opened this issue Jan 31, 2025 · 1 comment
Assignees

Comments

@robstryker
Copy link

JavaSearchGenericTypeTests.testParameterizedTypeSingleArgument02 is a test that demonstrates the bug.

The resolved source type should have a unique key like this:

Lg1/t/s/def/Generic<Ljava/lang/Exception;>.Member;

But our bindings are generating it with a key like this:

Lg1/t/s/def/Generic$Member<>;

With the incorrect key, our dom-search can't look for the proper signature.

This also causes normal search to fail if we run eclipse with the dom-based-operations but the normal search. So this is a bug in dom-based operations that needs to be fixed regardless.

Many test cases appear to be failing over this or a similar issue.

@robstryker robstryker self-assigned this Jan 31, 2025
@robstryker
Copy link
Author

This issue also brings up the possible difference between key and signature. The API doesn't really distinguish but I know that different calls often need slightly different syntax, which is annoying. I believe I made a small PR to address this in a different part of the code earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant