-
Notifications
You must be signed in to change notification settings - Fork 99
Prefer not to search for references within JRE when using --release #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
On the other hand: Even if the release options refers to another JDK, then the available/used JDK will still call the method, so it is actually referenced at runtime. |
Not sure what you mean. If it is a different method, we can't refer to actual JDK which compiler is using currently, because it may not exist here / changed signature etc. So if it is incompatible / not existing method in the current JDK, it will be not called by current JDK because it is technically not possible. This is the main point of the |
Probably 99% signatures will not depend on JDK version but those would be excluded from search just because some may have changed. |
Check ct.sym content. If that would be 99% we would not have so many files there. For user it doesn't matter if it is 1% or 10%, the data we use would be seemingly "randomly" correct or incorrect... |
Using |
- modify JavaSearchPage.updateOKStatus() to check if release set is less than the default JRE in which case, issue a warning message on the page - fixes eclipse-jdt#2017
@stephan-herrmann I have posted a patch which check for --release being set lower than default JRE and a warning is issued on the Java Search page. Let me know if this satisfies what you were looking for and if any tweaks are needed. |
From a first glimpse this looks good. I'll check out the branch to see it in action soonish. |
- modify JavaSearchPage.updateOKStatus() to check if release set is less than the default JRE in which case, issue a warning message on the page - fixes eclipse-jdt#2017
Reference search operates on sources, but when using
--release X
while only a JDK Y (Y>X) is installed / configured, then no sources of the desired version are available.Possible impact:
For that reason I suggest that the Java Search dialog should detect this situation and when
--release
doesn't match the physical JDK thenThe text was updated successfully, but these errors were encountered: