Skip to content

Editor formats "record" as keyword #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jukzi opened this issue Jan 20, 2025 · 1 comment · May be fixed by #2137
Open

Editor formats "record" as keyword #1953

jukzi opened this issue Jan 20, 2025 · 1 comment · May be fixed by #2137
Labels
bug Something isn't working

Comments

@jukzi
Copy link
Contributor

jukzi commented Jan 20, 2025

Example in org.eclipse.jdt.internal.core.builder.State.record(String, char[][][], char[][], char[][], char[], ArrayList)

Image

In this context "record" is not a keyword but simply a method name.
@jukzi jukzi added the bug Something isn't working label Jan 20, 2025
@zelenyhleb
Copy link
Contributor

Same for sealed and permits:
Image

Screenshot taken on workspace-launched jdt built from current master branch.

zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 5, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
88a4ffa 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting,
so change does not add any regression.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 5, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
55b40ef 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting,
so change does not add any regression.

Signed-off-by: Nikifor Fedorov <[email protected]>
@zelenyhleb zelenyhleb linked a pull request Apr 5, 2025 that will close this issue
Open
3 tasks
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 5, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
730db3a 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 8, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
c1a6ba6 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 14, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
fcc4772 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 14, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
0a93f67 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 14, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
8624144 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 16, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
d52a209 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 20, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
d28aa1d 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue Apr 27, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
c537f38 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
jjohnstn pushed a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue May 1, 2025
@zelenyhleb @jjohnstn
[eclipse-jdt#1953] Editor formats "record" as keyword
d009d2f 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
zelenyhleb added a commit to zelenyhleb/eclipse.jdt.ui that referenced this issue May 3, 2025
@zelenyhleb
[eclipse-jdt#1953] Editor formats "record" as keyword
9b4cb33 
Removed Token-level styling for contextual keywords: record, sealed,
permits, non-sealed. Semantic highlighting for these keywords was
already provided with
org.eclipse.jdt.internal.ui.javaeditor.SemanticHighlightings.RestrictedIdentifiersHighlighting.

Signed-off-by: Nikifor Fedorov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@zelenyhleb @jukzi