Skip to content

Commit 2622a10

Browse files
Remove references to v1 embedding for compatibility with Flutter 3.29
Inspired from flutter/packages#6494
1 parent 507a250 commit 2622a10

File tree

6 files changed

+11
-29
lines changed

6 files changed

+11
-29
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
.idea/

flutter-hms-map/android/src/main/java/com/huawei/hms/flutter/map/HmsMap.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void onAttachedToActivity(@NonNull ActivityPluginBinding activityPluginBi
9292
flutterPluginBinding.getPlatformViewRegistry()
9393
.registerViewFactory(Channel.CHANNEL,
9494
new MapFactory(state, flutterPluginBinding.getBinaryMessenger(), activityPluginBinding.getActivity(),
95-
lifecycle, null, activityPluginBinding.getActivity().hashCode()));
95+
lifecycle, activityPluginBinding.getActivity().hashCode()));
9696
}
9797

9898
@Override

flutter-hms-map/android/src/main/java/com/huawei/hms/flutter/map/map/MapBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@ class MapBuilder implements MapMethods {
9898

9999
MapController build(final int id, @NonNull final Context context, final Activity mActivity,
100100
final AtomicInteger state, final BinaryMessenger binaryMessenger, final Application application,
101-
final Lifecycle lifecycle, final PluginRegistry.Registrar registrar, final int activityHashCode) {
101+
final Lifecycle lifecycle, final int activityHashCode) {
102102
final MapController controller = new MapController(id, context, mActivity, state, binaryMessenger, application,
103-
lifecycle, registrar, activityHashCode, options);
103+
lifecycle, activityHashCode, options);
104104
controller.init();
105105
controller.setAllGesturesEnabled(allGesturesEnabled);
106106
controller.setScrollGesturesEnabledDuringRotateOrZoom(scrollGesturesEnabledDuringRotateOrZoom);

flutter-hms-map/android/src/main/java/com/huawei/hms/flutter/map/map/MapController.java

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,6 @@ final class MapController
8282

8383
private final Application mApplication;
8484

85-
private final PluginRegistry.Registrar registrar;
86-
8785
private final MapView mapView;
8886

8987
private HuaweiMap huaweiMap;
@@ -154,7 +152,7 @@ final class MapController
154152

155153
MapController(final int id, final Context context, final Activity mActivity, final AtomicInteger activityState,
156154
final BinaryMessenger binaryMessenger, final Application application, final Lifecycle lifecycle,
157-
final PluginRegistry.Registrar registrar, final int registrarActivityHashCode, final HuaweiMapOptions options) {
155+
final int registrarActivityHashCode, final HuaweiMapOptions options) {
158156
this.context = context;
159157
this.activityState = activityState;
160158
mapView = new MapView(mActivity, options);
@@ -164,7 +162,6 @@ final class MapController
164162
methodChannel.setMethodCallHandler(this);
165163
mApplication = application;
166164
this.lifecycle = lifecycle;
167-
this.registrar = registrar;
168165
activityHashCode = registrarActivityHashCode;
169166
mapUtils = new MapUtils(methodChannel, compactness, application);
170167
mapListenerHandler = new MapListenerHandler(id, mapUtils, methodChannel, application);
@@ -952,22 +949,10 @@ private void updateMyLocationSettings() {
952949
}
953950

954951
private int getActivityHashCode() {
955-
if (registrar != null) {
956-
Activity activity = registrar.activity();
957-
if (activity != null) {
958-
return activity.hashCode();
959-
}
960-
}
961952
return activityHashCode;
962953
}
963954

964955
private Application getApplication() {
965-
if (registrar != null) {
966-
Activity activity = registrar.activity();
967-
if (activity != null) {
968-
return activity.getApplication();
969-
}
970-
}
971956
return mApplication;
972957
}
973958

flutter-hms-map/android/src/main/java/com/huawei/hms/flutter/map/map/MapFactory.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,14 @@ public class MapFactory extends PlatformViewFactory {
5151

5252
private final Lifecycle lifecycle;
5353

54-
private final PluginRegistry.Registrar registrar;
55-
5654
public MapFactory(final AtomicInteger state, final BinaryMessenger binaryMessenger, final Activity mActivity,
57-
final Lifecycle lifecycle, final PluginRegistry.Registrar registrar, final int activityHashCode) {
55+
final Lifecycle lifecycle, final int activityHashCode) {
5856
super(StandardMessageCodec.INSTANCE);
5957
mActivityState = state;
6058
this.binaryMessenger = binaryMessenger;
6159
this.application = mActivity.getApplication();
6260
this.activityHashCode = activityHashCode;
6361
this.lifecycle = lifecycle;
64-
this.registrar = registrar;
6562
this.mActivity = mActivity;
6663
}
6764

@@ -96,7 +93,6 @@ public PlatformView create(final Context context, final int id, final Object arg
9693
if (params.containsKey(Param.HEAT_MAPS_TO_INSERT)) {
9794
builder.setHeatMaps((List<HashMap<String, Object>>) params.get(Param.HEAT_MAPS_TO_INSERT));
9895
}
99-
return builder.build(id, context, mActivity, mActivityState, binaryMessenger, application, lifecycle, registrar,
100-
activityHashCode);
96+
return builder.build(id, context, mActivity, mActivityState, binaryMessenger, application, lifecycle, activityHashCode);
10197
}
10298
}

flutter-hms-map/android/src/main/java/com/huawei/hms/flutter/map/utils/Convert.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474

7575
import io.flutter.plugin.common.BinaryMessenger;
7676
import io.flutter.plugin.common.MethodChannel;
77-
import io.flutter.view.FlutterMain;
77+
import io.flutter.FlutterInjector;
7878

7979
import org.json.JSONArray;
8080
import org.json.JSONException;
@@ -197,15 +197,15 @@ private static BitmapDescriptor toBitmapDescriptor(final Object o) {
197197
case Param.FROM_ASSET:
198198
if (data.size() == 2) {
199199
return BitmapDescriptorFactory.fromAsset(
200-
FlutterMain.getLookupKeyForAsset(Convert.toString(data.get(1))));
200+
FlutterInjector.instance().flutterLoader().getLookupKeyForAsset(Convert.toString(data.get(1))));
201201
} else {
202202
return BitmapDescriptorFactory.fromAsset(
203-
FlutterMain.getLookupKeyForAsset(Convert.toString(data.get(1)), Convert.toString(data.get(2))));
203+
FlutterInjector.instance().flutterLoader().getLookupKeyForAsset(Convert.toString(data.get(1)), Convert.toString(data.get(2))));
204204
}
205205
case Param.FROM_ASSET_IMAGE:
206206
if (data.size() == 3) {
207207
return BitmapDescriptorFactory.fromAsset(
208-
FlutterMain.getLookupKeyForAsset(Convert.toString(data.get(1))));
208+
FlutterInjector.instance().flutterLoader().getLookupKeyForAsset(Convert.toString(data.get(1))));
209209
} else {
210210
throw new IllegalArgumentException(Param.ERROR);
211211
}

0 commit comments

Comments
 (0)