Skip to content

Branch 3.x (3.2.x) fails assert #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
pele1410 opened this issue Oct 17, 2024 · 2 comments · Fixed by #5339
Closed
1 task done

Branch 3.x (3.2.x) fails assert #5338

pele1410 opened this issue Oct 17, 2024 · 2 comments · Fixed by #5339
Labels
triage Issue pending classification

Comments

@pele1410
Copy link

Is there an already existing issue for this?

  • I have searched the existing issues

Expected behavior

I expect that building on the 3.x branch succeeds.

Current behavior

The build fails a static assert

FASTDDS_TODO_BEFORE(3, 2, "Pass keyFlag in serializedPayload, and always pass input data upwards");

The full error

In file included from /work/fastdds/include/fastdds/fastdds_dll.hpp:23,
                 from /work/fastdds/include/fastdds/rtps/common/EntityId_t.hpp:22,
                 from /work/fastdds/src/cpp/rtps/messages/MessageReceiver.cpp:24:
/work/fastdds/src/cpp/rtps/messages/MessageReceiver.cpp: In member function ‘bool eprosima::fastdds::rtps::MessageReceiver::proc_Submsg_Data(eprosima::fastdds::rtps::CDRMessage_t*, eprosima::fastdds::rtps::SubmessageHeader_t*, eprosima::fastdds::rtps::EntityId_t&, bool) const’:
/ros_work/fastdds-spy/build/fastdds/include/fastdds/config.hpp:123:51: error: static assertion failed: TODO before version 3.2 : "Pass keyFlag in serializedPayload, and always pass input data upwards"
  123 |     static_assert((FASTDDS_VERSION_MAJOR < major) ||                                   \
      |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  124 |             (FASTDDS_VERSION_MAJOR == major && FASTDDS_VERSION_MINOR < minor),  \
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/work/fastdds/src/cpp/rtps/messages/MessageReceiver.cpp:870:13: note: in expansion of macro ‘FASTDDS_TODO_BEFORE’
  870 |             FASTDDS_TODO_BEFORE(3, 2, "Pass keyFlag in serializedPayload, and always pass input data upwards");
      |             ^~~~~~~~~~~~~~~~~~~
gmake[2]: *** [src/cpp/CMakeFiles/fastdds.dir/build.make:1924: src/cpp/CMakeFiles/fastdds.dir/rtps/messages/MessageReceiver.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [CMakeFiles/Makefile2:976: src/cpp/CMakeFiles/fastdds.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

Steps to reproduce

Clone the repository with the 3.x branch.
colcon build

Fast DDS version/commit

Branch 3.x

Platform/Architecture

Other. Please specify in Additional context section.

Transport layer

Default configuration, UDPv4 & SHM

Additional context

Building in an Ubuntu 24.04 docker container (docker.io/library/ubuntu:noble)

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

@pele1410 pele1410 added the triage Issue pending classification label Oct 17, 2024
@pele1410
Copy link
Author

This started after the following commit it seems
95ea270

@JesusPoderoso
Copy link
Contributor

Hi @pele1410, thanks for your report.
We are working on the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue pending classification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants