Adding default ctor to interprocess_semaphore (#1169)

* Fix build fail in ROS-CI.

Signed-off-by: AdolfoMartinez <[email protected]>

* Apply suggestions from code review

Signed-off-by: Miguel Company <[email protected]>

* Fix boost::interprocess::semaphore initialization.

Signed-off-by: AdolfoMartinez <[email protected]>

* Fix CXX_STANDARD on boost try_compile

Co-authored-by: Miguel Company <[email protected]>

Author: adolfomarver

cmake/modules/FindThirdpartyBoost.cmake

@@ -23,6 +23,7 @@ try_compile(IS_THIRDPARTY_BOOST_OK
         ${CMAKE_BINARY_DIR}
         ${PROJECT_SOURCE_DIR}/thirdparty/boost/test/ThirdpartyBoostCompile_test.cpp
          CMAKE_FLAGS "-DINCLUDE_DIRECTORIES=${THIRDPARTY_BOOST_INCLUDE_DIR}"
+         CXX_STANDARD 11
          LINK_LIBRARIES ${THIRDPARTY_BOOST_LINK_LIBS}
          OUTPUT_VARIABLE OUT
     )

src/cpp/rtps/transport/shared_mem/RobustInterprocessCondition.hpp

@@ -161,7 +161,7 @@ class RobustInterprocessCondition
 
     struct SemaphoreNode
     {
-        bi::interprocess_semaphore sem;
+        bi::interprocess_semaphore sem {0};
         uint32_t next;
         uint32_t prev;
     };

thirdparty/boost/include/boost/interprocess/sync/interprocess_semaphore.hpp

@@ -59,9 +59,10 @@ class interprocess_semaphore
    interprocess_semaphore &operator=(const interprocess_semaphore &);
    #endif   //#ifndef BOOST_INTERPROCESS_DOXYGEN_INVOKED
    public:
+
    //!Creates a interprocess_semaphore with the given initial count.
-   //!interprocess_exception if there is an error.*/
-   interprocess_semaphore(unsigned int initialCount = 0);
+   //!interprocess_exception if there is an error.
+   interprocess_semaphore(unsigned int initialCount);
 
    //!Destroys the interprocess_semaphore.
    //!Does not throw

thirdparty/boost/test/ThirdpartyBoostCompile_test.cpp

@@ -16,6 +16,7 @@
 #include <boost/interprocess/managed_shared_memory.hpp>
 #include <boost/interprocess/sync/interprocess_condition.hpp>
 #include <boost/interprocess/sync/named_mutex.hpp>
+#include <boost/interprocess/sync/interprocess_semaphore.hpp>
 #include <boost/interprocess/offset_ptr.hpp>
 #include <boost/thread/thread_time.hpp>
 
@@ -31,6 +32,7 @@ class ThirdpartyBoostCompileTest
     ThirdpartyBoostCompileTest()
     {
         boost::interprocess::named_mutex::remove("foo");
+        boost::interprocess::interprocess_semaphore sem {0};
 
         try
         {