Refs #22682: Apply suggested changes. Update send_reply signature.

Carlosespicur · Carlosespicur · commit 52695fa12097 · 2025-03-03T16:08:49.000+01:00
Signed-off-by: Carlosespicur &lt;carlosespicur@proton.me&gt;
diff --git a/include/fastdds/dds/rpc/Replier.hpp b/include/fastdds/dds/rpc/Replier.hpp
@@ -54,7 +54,7 @@ class Replier : public RPCEntity
      */
     virtual ReturnCode_t send_reply(
             void* data,
-            RequestInfo& info) = 0;
+            const RequestInfo& info) = 0;
 
     /**
      * @brief Take a request message from the Replier DataReader's history.
diff --git a/src/cpp/fastdds/rpc/ReplierImpl.cpp b/src/cpp/fastdds/rpc/ReplierImpl.cpp
@@ -48,7 +48,7 @@ const std::string& ReplierImpl::get_service_name() const
 
 ReturnCode_t ReplierImpl::send_reply(
         void* data,
-        RequestInfo& info)
+        const RequestInfo& info)
 {
     FASTDDS_TODO_BEFORE(3, 3, "Implement matching algorithm");
 
diff --git a/src/cpp/fastdds/rpc/ReplierImpl.hpp b/src/cpp/fastdds/rpc/ReplierImpl.hpp
@@ -68,7 +68,7 @@ class ReplierImpl : public Replier
      */
     ReturnCode_t send_reply(
             void* data,
-            RequestInfo& info) override;
+            const RequestInfo& info) override;
 
     /**
      * @brief Take a request message from the Replier DataReader's history.
diff --git a/test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.cpp b/test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.cpp
@@ -102,7 +102,7 @@ void ReqRepHelloWorldReplier::init_with_custom_qos(
 }
 
 void ReqRepHelloWorldReplier::newNumber(
-        RequestInfo& info,
+        const RequestInfo& info,
         uint16_t number)
 {
     HelloWorld hello;
diff --git a/test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.hpp b/test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.hpp
@@ -62,7 +62,7 @@ class ReqRepHelloWorldReplier
     }
 
     void newNumber(
-            eprosima::fastdds::dds::rpc::RequestInfo& info,
+            const eprosima::fastdds::dds::rpc::RequestInfo& info,
             uint16_t number);
 
     void wait_discovery();
diff --git a/test/blackbox/api/dds-pim/TCPReqRepHelloWorldReplier.cpp b/test/blackbox/api/dds-pim/TCPReqRepHelloWorldReplier.cpp
@@ -147,7 +147,7 @@ void TCPReqRepHelloWorldReplier::init(
 }
 
 void TCPReqRepHelloWorldReplier::newNumber(
-        RequestInfo& info,
+        const RequestInfo& info,
         uint16_t number)
 {
     HelloWorld hello;
diff --git a/test/blackbox/api/dds-pim/TCPReqRepHelloWorldReplier.hpp b/test/blackbox/api/dds-pim/TCPReqRepHelloWorldReplier.hpp
@@ -62,7 +62,7 @@ class TCPReqRepHelloWorldReplier
     }
 
     void newNumber(
-            eprosima::fastdds::dds::rpc::RequestInfo& info,
+            const eprosima::fastdds::dds::rpc::RequestInfo& info,
             uint16_t number);
 
     void wait_discovery(

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ const std::string& ReplierImpl::get_service_name() const`
`48`	`48`
`49`	`49`	`ReturnCode_t ReplierImpl::send_reply(`
`50`	`50`	`void* data,`
`51`		`- RequestInfo& info)`
	`51`	`+ const RequestInfo& info)`
`52`	`52`	`{`
`53`	`53`	`FASTDDS_TODO_BEFORE(3, 3, "Implement matching algorithm");`
`54`	`54`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ void ReqRepHelloWorldReplier::init_with_custom_qos(`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`void ReqRepHelloWorldReplier::newNumber(`
`105`		`- RequestInfo& info,`
	`105`	`+ const RequestInfo& info,`
`106`	`106`	`uint16_t number)`
`107`	`107`	`{`
`108`	`108`	`HelloWorld hello;`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ class ReqRepHelloWorldReplier`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`void newNumber(`
`65`		`- eprosima::fastdds::dds::rpc::RequestInfo& info,`
	`65`	`+ const eprosima::fastdds::dds::rpc::RequestInfo& info,`
`66`	`66`	`uint16_t number);`
`67`	`67`
`68`	`68`	`void wait_discovery();`
Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ void TCPReqRepHelloWorldReplier::init(`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`void TCPReqRepHelloWorldReplier::newNumber(`
`150`		`- RequestInfo& info,`
	`150`	`+ const RequestInfo& info,`
`151`	`151`	`uint16_t number)`
`152`	`152`	`{`
`153`	`153`	`HelloWorld hello;`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ class TCPReqRepHelloWorldReplier`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`void newNumber(`
`65`		`- eprosima::fastdds::dds::rpc::RequestInfo& info,`
	`65`	`+ const eprosima::fastdds::dds::rpc::RequestInfo& info,`
`66`	`66`	`uint16_t number);`
`67`	`67`
`68`	`68`	`void wait_discovery(`