Be less strict with parameter lengths (#5225) (#5247)

mergify[bot] · MiguelCompany · JesusPoderoso · web-flow · commit 48a8776a28b2 · 2024-11-20T16:27:18.000+01:00
* Be less strict with parameter lengths (#5225) * Refs #21537. Add regression test for interoperability issue. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Add regression test for big parameters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Fix builtin deserialization length checks. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Special cases in test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Extend test to full non-custom range. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Extend parameter size to 64K. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21537. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21638. Fix windows warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 7b111f9) # Conflicts: # src/cpp/fastdds/core/policy/ParameterSerializer.hpp * Refs #21638: Fix conflicts Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Fix unit tests build Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
diff --git a/src/cpp/fastdds/core/policy/ParameterSerializer.hpp b/src/cpp/fastdds/core/policy/ParameterSerializer.hpp
@@ -251,7 +251,7 @@ inline bool ParameterSerializer<ParameterLocator_t>::read_content_from_cdr_messa
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_LOCATOR_LENGTH)
+    if (parameter_length < PARAMETER_LOCATOR_LENGTH)
     {
         return false;
     }
@@ -273,7 +273,7 @@ inline bool ParameterSerializer<ParameterKey_t>::read_content_from_cdr_message(
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_KEY_HASH_LENGTH)
+    if (parameter_length < PARAMETER_KEY_HASH_LENGTH)
     {
         return false;
     }
@@ -343,7 +343,7 @@ inline bool ParameterSerializer<ParameterPort_t>::read_content_from_cdr_message(
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_PORT_LENGTH)
+    if (parameter_length < PARAMETER_PORT_LENGTH)
     {
         return false;
     }
@@ -367,7 +367,7 @@ inline bool ParameterSerializer<ParameterGuid_t>::read_content_from_cdr_message(
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_GUID_LENGTH)
+    if (parameter_length < PARAMETER_GUID_LENGTH)
     {
         return false;
     }
@@ -394,7 +394,7 @@ inline bool ParameterSerializer<ParameterProtocolVersion_t>::read_content_from_c
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_PROTOCOL_LENGTH)
+    if (parameter_length < PARAMETER_PROTOCOL_LENGTH)
     {
         return false;
     }
@@ -422,7 +422,7 @@ inline bool ParameterSerializer<ParameterVendorId_t>::read_content_from_cdr_mess
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_VENDOR_LENGTH)
+    if (parameter_length < PARAMETER_VENDOR_LENGTH)
     {
         return false;
     }
@@ -447,7 +447,7 @@ inline bool ParameterSerializer<ParameterIP4Address_t>::read_content_from_cdr_me
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_IP4_LENGTH)
+    if (parameter_length < PARAMETER_IP4_LENGTH)
     {
         return false;
     }
@@ -473,7 +473,7 @@ inline bool ParameterSerializer<ParameterBool_t>::read_content_from_cdr_message(
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_BOOL_LENGTH)
+    if (parameter_length < PARAMETER_BOOL_LENGTH)
     {
         return false;
     }
@@ -501,7 +501,7 @@ inline bool ParameterSerializer<ParameterStatusInfo_t>::read_content_from_cdr_me
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_STATUS_INFO_LENGTH)
+    if (parameter_length < PARAMETER_STATUS_INFO_LENGTH)
     {
         return false;
     }
@@ -530,7 +530,7 @@ inline bool ParameterSerializer<ParameterCount_t>::read_content_from_cdr_message
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_COUNT_LENGTH)
+    if (parameter_length < PARAMETER_COUNT_LENGTH)
     {
         return false;
     }
@@ -552,7 +552,7 @@ inline bool ParameterSerializer<ParameterEntityId_t>::read_content_from_cdr_mess
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_ENTITYID_LENGTH)
+    if (parameter_length < PARAMETER_ENTITYID_LENGTH)
     {
         return false;
     }
@@ -576,7 +576,7 @@ inline bool ParameterSerializer<ParameterTime_t>::read_content_from_cdr_message(
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_TIME_LENGTH)
+    if (parameter_length < PARAMETER_TIME_LENGTH)
     {
         return false;
     }
@@ -604,7 +604,7 @@ inline bool ParameterSerializer<ParameterBuiltinEndpointSet_t>::read_content_fro
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_BUILTINENDPOINTSET_LENGTH)
+    if (parameter_length < PARAMETER_BUILTINENDPOINTSET_LENGTH)
     {
         return false;
     }
@@ -626,7 +626,7 @@ inline bool ParameterSerializer<ParameterNetworkConfigSet_t>::read_content_from_
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_NETWORKCONFIGSET_LENGTH)
+    if (parameter_length < PARAMETER_NETWORKCONFIGSET_LENGTH)
     {
         return false;
     }
@@ -783,7 +783,7 @@ inline bool ParameterSerializer<ParameterSampleIdentity_t>::read_content_from_cd
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_SAMPLEIDENTITY_LENGTH)
+    if (parameter_length < PARAMETER_SAMPLEIDENTITY_LENGTH)
     {
         return false;
     }
@@ -1061,7 +1061,7 @@ inline bool ParameterSerializer<ParameterParticipantSecurityInfo_t>::read_conten
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_PARTICIPANT_SECURITY_INFO_LENGTH)
+    if (parameter_length < PARAMETER_PARTICIPANT_SECURITY_INFO_LENGTH)
     {
         return false;
     }
@@ -1087,7 +1087,7 @@ inline bool ParameterSerializer<ParameterEndpointSecurityInfo_t>::read_content_f
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_ENDPOINT_SECURITY_INFO_LENGTH)
+    if (parameter_length < PARAMETER_ENDPOINT_SECURITY_INFO_LENGTH)
     {
         return false;
     }
diff --git a/src/cpp/fastdds/core/policy/QosPoliciesSerializer.hpp b/src/cpp/fastdds/core/policy/QosPoliciesSerializer.hpp
@@ -97,7 +97,7 @@ inline bool QosPoliciesSerializer<DurabilityQosPolicy>::read_content_from_cdr_me
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_KIND_LENGTH)
+    if (parameter_length < PARAMETER_KIND_LENGTH)
     {
         return false;
     }
@@ -126,7 +126,7 @@ inline bool QosPoliciesSerializer<DeadlineQosPolicy>::read_content_from_cdr_mess
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_TIME_LENGTH)
+    if (parameter_length < PARAMETER_TIME_LENGTH)
     {
         return false;
     }
@@ -155,7 +155,7 @@ inline bool QosPoliciesSerializer<LatencyBudgetQosPolicy>::read_content_from_cdr
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_TIME_LENGTH)
+    if (parameter_length < PARAMETER_TIME_LENGTH)
     {
         return false;
     }
@@ -190,7 +190,7 @@ inline bool QosPoliciesSerializer<LivelinessQosPolicy>::read_content_from_cdr_me
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_KIND_LENGTH + PARAMETER_TIME_LENGTH)
+    if (parameter_length < PARAMETER_KIND_LENGTH + PARAMETER_TIME_LENGTH)
     {
         return false;
     }
@@ -229,7 +229,7 @@ inline bool QosPoliciesSerializer<ReliabilityQosPolicy>::read_content_from_cdr_m
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_KIND_LENGTH + PARAMETER_TIME_LENGTH)
+    if (parameter_length < PARAMETER_KIND_LENGTH + PARAMETER_TIME_LENGTH)
     {
         return false;
     }
@@ -263,7 +263,7 @@ inline bool QosPoliciesSerializer<OwnershipQosPolicy>::read_content_from_cdr_mes
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_KIND_LENGTH)
+    if (parameter_length < PARAMETER_KIND_LENGTH)
     {
         return false;
     }
@@ -292,7 +292,7 @@ inline bool QosPoliciesSerializer<DestinationOrderQosPolicy>::read_content_from_
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_KIND_LENGTH)
+    if (parameter_length < PARAMETER_KIND_LENGTH)
     {
         return false;
     }
@@ -323,7 +323,7 @@ inline bool QosPoliciesSerializer<ResourceLimitsQosPolicy>::read_content_from_cd
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != 12)
+    if (parameter_length < 12)
     {
         return false;
     }
@@ -357,7 +357,7 @@ inline bool QosPoliciesSerializer<TimeBasedFilterQosPolicy>::read_content_from_c
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_TIME_LENGTH)
+    if (parameter_length < PARAMETER_TIME_LENGTH)
     {
         return false;
     }
@@ -397,7 +397,7 @@ inline bool QosPoliciesSerializer<PresentationQosPolicy>::read_content_from_cdr_
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_PRESENTATION_LENGTH)
+    if (parameter_length < PARAMETER_PRESENTATION_LENGTH)
     {
         return false;
     }
@@ -516,7 +516,7 @@ inline bool QosPoliciesSerializer<HistoryQosPolicy>::read_content_from_cdr_messa
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_KIND_LENGTH + 4)
+    if (parameter_length < PARAMETER_KIND_LENGTH + 4)
     {
         return false;
     }
@@ -553,7 +553,7 @@ inline bool QosPoliciesSerializer<DurabilityServiceQosPolicy>::read_content_from
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_TIME_LENGTH + PARAMETER_KIND_LENGTH + 16)
+    if (parameter_length < PARAMETER_TIME_LENGTH + PARAMETER_KIND_LENGTH + 16)
     {
         return false;
     }
@@ -588,7 +588,7 @@ inline bool QosPoliciesSerializer<LifespanQosPolicy>::read_content_from_cdr_mess
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_TIME_LENGTH)
+    if (parameter_length < PARAMETER_TIME_LENGTH)
     {
         return false;
     }
@@ -615,7 +615,7 @@ inline bool QosPoliciesSerializer<OwnershipStrengthQosPolicy>::read_content_from
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != 4)
+    if (parameter_length < 4)
     {
         return false;
     }
@@ -638,7 +638,7 @@ inline bool QosPoliciesSerializer<TransportPriorityQosPolicy>::read_content_from
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != 4)
+    if (parameter_length < 4)
     {
         return false;
     }
@@ -800,7 +800,7 @@ inline bool QosPoliciesSerializer<DisablePositiveACKsQosPolicy>::read_content_fr
         fastrtps::rtps::CDRMessage_t* cdr_message,
         const uint16_t parameter_length)
 {
-    if (parameter_length != PARAMETER_BOOL_LENGTH)
+    if (parameter_length < PARAMETER_BOOL_LENGTH)
     {
         return false;
     }
diff --git a/test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp b/test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ inline bool ParameterSerializer<ParameterLocator_t>::read_content_from_cdr_messa`
`251`	`251`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`252`	`252`	`const uint16_t parameter_length)`
`253`	`253`	`{`
`254`		`- if (parameter_length != PARAMETER_LOCATOR_LENGTH)`
	`254`	`+ if (parameter_length < PARAMETER_LOCATOR_LENGTH)`
`255`	`255`	`{`
`256`	`256`	`return false;`
`257`	`257`	`}`
`@@ -273,7 +273,7 @@ inline bool ParameterSerializer<ParameterKey_t>::read_content_from_cdr_message(`
`273`	`273`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`274`	`274`	`const uint16_t parameter_length)`
`275`	`275`	`{`
`276`		`- if (parameter_length != PARAMETER_KEY_HASH_LENGTH)`
	`276`	`+ if (parameter_length < PARAMETER_KEY_HASH_LENGTH)`
`277`	`277`	`{`
`278`	`278`	`return false;`
`279`	`279`	`}`
`@@ -343,7 +343,7 @@ inline bool ParameterSerializer<ParameterPort_t>::read_content_from_cdr_message(`
`343`	`343`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`344`	`344`	`const uint16_t parameter_length)`
`345`	`345`	`{`
`346`		`- if (parameter_length != PARAMETER_PORT_LENGTH)`
	`346`	`+ if (parameter_length < PARAMETER_PORT_LENGTH)`
`347`	`347`	`{`
`348`	`348`	`return false;`
`349`	`349`	`}`
`@@ -367,7 +367,7 @@ inline bool ParameterSerializer<ParameterGuid_t>::read_content_from_cdr_message(`
`367`	`367`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`368`	`368`	`const uint16_t parameter_length)`
`369`	`369`	`{`
`370`		`- if (parameter_length != PARAMETER_GUID_LENGTH)`
	`370`	`+ if (parameter_length < PARAMETER_GUID_LENGTH)`
`371`	`371`	`{`
`372`	`372`	`return false;`
`373`	`373`	`}`
`@@ -394,7 +394,7 @@ inline bool ParameterSerializer<ParameterProtocolVersion_t>::read_content_from_c`
`394`	`394`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`395`	`395`	`const uint16_t parameter_length)`
`396`	`396`	`{`
`397`		`- if (parameter_length != PARAMETER_PROTOCOL_LENGTH)`
	`397`	`+ if (parameter_length < PARAMETER_PROTOCOL_LENGTH)`
`398`	`398`	`{`
`399`	`399`	`return false;`
`400`	`400`	`}`
`@@ -422,7 +422,7 @@ inline bool ParameterSerializer<ParameterVendorId_t>::read_content_from_cdr_mess`
`422`	`422`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`423`	`423`	`const uint16_t parameter_length)`
`424`	`424`	`{`
`425`		`- if (parameter_length != PARAMETER_VENDOR_LENGTH)`
	`425`	`+ if (parameter_length < PARAMETER_VENDOR_LENGTH)`
`426`	`426`	`{`
`427`	`427`	`return false;`
`428`	`428`	`}`
`@@ -447,7 +447,7 @@ inline bool ParameterSerializer<ParameterIP4Address_t>::read_content_from_cdr_me`
`447`	`447`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`448`	`448`	`const uint16_t parameter_length)`
`449`	`449`	`{`
`450`		`- if (parameter_length != PARAMETER_IP4_LENGTH)`
	`450`	`+ if (parameter_length < PARAMETER_IP4_LENGTH)`
`451`	`451`	`{`
`452`	`452`	`return false;`
`453`	`453`	`}`
`@@ -473,7 +473,7 @@ inline bool ParameterSerializer<ParameterBool_t>::read_content_from_cdr_message(`
`473`	`473`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`474`	`474`	`const uint16_t parameter_length)`
`475`	`475`	`{`
`476`		`- if (parameter_length != PARAMETER_BOOL_LENGTH)`
	`476`	`+ if (parameter_length < PARAMETER_BOOL_LENGTH)`
`477`	`477`	`{`
`478`	`478`	`return false;`
`479`	`479`	`}`
`@@ -501,7 +501,7 @@ inline bool ParameterSerializer<ParameterStatusInfo_t>::read_content_from_cdr_me`
`501`	`501`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`502`	`502`	`const uint16_t parameter_length)`
`503`	`503`	`{`
`504`		`- if (parameter_length != PARAMETER_STATUS_INFO_LENGTH)`
	`504`	`+ if (parameter_length < PARAMETER_STATUS_INFO_LENGTH)`
`505`	`505`	`{`
`506`	`506`	`return false;`
`507`	`507`	`}`
`@@ -530,7 +530,7 @@ inline bool ParameterSerializer<ParameterCount_t>::read_content_from_cdr_message`
`530`	`530`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`531`	`531`	`const uint16_t parameter_length)`
`532`	`532`	`{`
`533`		`- if (parameter_length != PARAMETER_COUNT_LENGTH)`
	`533`	`+ if (parameter_length < PARAMETER_COUNT_LENGTH)`
`534`	`534`	`{`
`535`	`535`	`return false;`
`536`	`536`	`}`
`@@ -552,7 +552,7 @@ inline bool ParameterSerializer<ParameterEntityId_t>::read_content_from_cdr_mess`
`552`	`552`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`553`	`553`	`const uint16_t parameter_length)`
`554`	`554`	`{`
`555`		`- if (parameter_length != PARAMETER_ENTITYID_LENGTH)`
	`555`	`+ if (parameter_length < PARAMETER_ENTITYID_LENGTH)`
`556`	`556`	`{`
`557`	`557`	`return false;`
`558`	`558`	`}`
`@@ -576,7 +576,7 @@ inline bool ParameterSerializer<ParameterTime_t>::read_content_from_cdr_message(`
`576`	`576`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`577`	`577`	`const uint16_t parameter_length)`
`578`	`578`	`{`
`579`		`- if (parameter_length != PARAMETER_TIME_LENGTH)`
	`579`	`+ if (parameter_length < PARAMETER_TIME_LENGTH)`
`580`	`580`	`{`
`581`	`581`	`return false;`
`582`	`582`	`}`
`@@ -604,7 +604,7 @@ inline bool ParameterSerializer<ParameterBuiltinEndpointSet_t>::read_content_fro`
`604`	`604`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`605`	`605`	`const uint16_t parameter_length)`
`606`	`606`	`{`
`607`		`- if (parameter_length != PARAMETER_BUILTINENDPOINTSET_LENGTH)`
	`607`	`+ if (parameter_length < PARAMETER_BUILTINENDPOINTSET_LENGTH)`
`608`	`608`	`{`
`609`	`609`	`return false;`
`610`	`610`	`}`
`@@ -626,7 +626,7 @@ inline bool ParameterSerializer<ParameterNetworkConfigSet_t>::read_content_from_`
`626`	`626`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`627`	`627`	`const uint16_t parameter_length)`
`628`	`628`	`{`
`629`		`- if (parameter_length != PARAMETER_NETWORKCONFIGSET_LENGTH)`
	`629`	`+ if (parameter_length < PARAMETER_NETWORKCONFIGSET_LENGTH)`
`630`	`630`	`{`
`631`	`631`	`return false;`
`632`	`632`	`}`
`@@ -783,7 +783,7 @@ inline bool ParameterSerializer<ParameterSampleIdentity_t>::read_content_from_cd`
`783`	`783`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`784`	`784`	`const uint16_t parameter_length)`
`785`	`785`	`{`
`786`		`- if (parameter_length != PARAMETER_SAMPLEIDENTITY_LENGTH)`
	`786`	`+ if (parameter_length < PARAMETER_SAMPLEIDENTITY_LENGTH)`
`787`	`787`	`{`
`788`	`788`	`return false;`
`789`	`789`	`}`
`@@ -1061,7 +1061,7 @@ inline bool ParameterSerializer<ParameterParticipantSecurityInfo_t>::read_conten`
`1061`	`1061`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`1062`	`1062`	`const uint16_t parameter_length)`
`1063`	`1063`	`{`
`1064`		`- if (parameter_length != PARAMETER_PARTICIPANT_SECURITY_INFO_LENGTH)`
	`1064`	`+ if (parameter_length < PARAMETER_PARTICIPANT_SECURITY_INFO_LENGTH)`
`1065`	`1065`	`{`
`1066`	`1066`	`return false;`
`1067`	`1067`	`}`
`@@ -1087,7 +1087,7 @@ inline bool ParameterSerializer<ParameterEndpointSecurityInfo_t>::read_content_f`
`1087`	`1087`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`1088`	`1088`	`const uint16_t parameter_length)`
`1089`	`1089`	`{`
`1090`		`- if (parameter_length != PARAMETER_ENDPOINT_SECURITY_INFO_LENGTH)`
	`1090`	`+ if (parameter_length < PARAMETER_ENDPOINT_SECURITY_INFO_LENGTH)`
`1091`	`1091`	`{`
`1092`	`1092`	`return false;`
`1093`	`1093`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ inline bool QosPoliciesSerializer<DurabilityQosPolicy>::read_content_from_cdr_me`
`97`	`97`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`98`	`98`	`const uint16_t parameter_length)`
`99`	`99`	`{`
`100`		`- if (parameter_length != PARAMETER_KIND_LENGTH)`
	`100`	`+ if (parameter_length < PARAMETER_KIND_LENGTH)`
`101`	`101`	`{`
`102`	`102`	`return false;`
`103`	`103`	`}`
`@@ -126,7 +126,7 @@ inline bool QosPoliciesSerializer<DeadlineQosPolicy>::read_content_from_cdr_mess`
`126`	`126`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`127`	`127`	`const uint16_t parameter_length)`
`128`	`128`	`{`
`129`		`- if (parameter_length != PARAMETER_TIME_LENGTH)`
	`129`	`+ if (parameter_length < PARAMETER_TIME_LENGTH)`
`130`	`130`	`{`
`131`	`131`	`return false;`
`132`	`132`	`}`
`@@ -155,7 +155,7 @@ inline bool QosPoliciesSerializer<LatencyBudgetQosPolicy>::read_content_from_cdr`
`155`	`155`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`156`	`156`	`const uint16_t parameter_length)`
`157`	`157`	`{`
`158`		`- if (parameter_length != PARAMETER_TIME_LENGTH)`
	`158`	`+ if (parameter_length < PARAMETER_TIME_LENGTH)`
`159`	`159`	`{`
`160`	`160`	`return false;`
`161`	`161`	`}`
`@@ -190,7 +190,7 @@ inline bool QosPoliciesSerializer<LivelinessQosPolicy>::read_content_from_cdr_me`
`190`	`190`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`191`	`191`	`const uint16_t parameter_length)`
`192`	`192`	`{`
`193`		`- if (parameter_length != PARAMETER_KIND_LENGTH + PARAMETER_TIME_LENGTH)`
	`193`	`+ if (parameter_length < PARAMETER_KIND_LENGTH + PARAMETER_TIME_LENGTH)`
`194`	`194`	`{`
`195`	`195`	`return false;`
`196`	`196`	`}`
`@@ -229,7 +229,7 @@ inline bool QosPoliciesSerializer<ReliabilityQosPolicy>::read_content_from_cdr_m`
`229`	`229`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`230`	`230`	`const uint16_t parameter_length)`
`231`	`231`	`{`
`232`		`- if (parameter_length != PARAMETER_KIND_LENGTH + PARAMETER_TIME_LENGTH)`
	`232`	`+ if (parameter_length < PARAMETER_KIND_LENGTH + PARAMETER_TIME_LENGTH)`
`233`	`233`	`{`
`234`	`234`	`return false;`
`235`	`235`	`}`
`@@ -263,7 +263,7 @@ inline bool QosPoliciesSerializer<OwnershipQosPolicy>::read_content_from_cdr_mes`
`263`	`263`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`264`	`264`	`const uint16_t parameter_length)`
`265`	`265`	`{`
`266`		`- if (parameter_length != PARAMETER_KIND_LENGTH)`
	`266`	`+ if (parameter_length < PARAMETER_KIND_LENGTH)`
`267`	`267`	`{`
`268`	`268`	`return false;`
`269`	`269`	`}`
`@@ -292,7 +292,7 @@ inline bool QosPoliciesSerializer<DestinationOrderQosPolicy>::read_content_from_`
`292`	`292`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`293`	`293`	`const uint16_t parameter_length)`
`294`	`294`	`{`
`295`		`- if (parameter_length != PARAMETER_KIND_LENGTH)`
	`295`	`+ if (parameter_length < PARAMETER_KIND_LENGTH)`
`296`	`296`	`{`
`297`	`297`	`return false;`
`298`	`298`	`}`
`@@ -323,7 +323,7 @@ inline bool QosPoliciesSerializer<ResourceLimitsQosPolicy>::read_content_from_cd`
`323`	`323`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`324`	`324`	`const uint16_t parameter_length)`
`325`	`325`	`{`
`326`		`- if (parameter_length != 12)`
	`326`	`+ if (parameter_length < 12)`
`327`	`327`	`{`
`328`	`328`	`return false;`
`329`	`329`	`}`
`@@ -357,7 +357,7 @@ inline bool QosPoliciesSerializer<TimeBasedFilterQosPolicy>::read_content_from_c`
`357`	`357`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`358`	`358`	`const uint16_t parameter_length)`
`359`	`359`	`{`
`360`		`- if (parameter_length != PARAMETER_TIME_LENGTH)`
	`360`	`+ if (parameter_length < PARAMETER_TIME_LENGTH)`
`361`	`361`	`{`
`362`	`362`	`return false;`
`363`	`363`	`}`
`@@ -397,7 +397,7 @@ inline bool QosPoliciesSerializer<PresentationQosPolicy>::read_content_from_cdr_`
`397`	`397`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`398`	`398`	`const uint16_t parameter_length)`
`399`	`399`	`{`
`400`		`- if (parameter_length != PARAMETER_PRESENTATION_LENGTH)`
	`400`	`+ if (parameter_length < PARAMETER_PRESENTATION_LENGTH)`
`401`	`401`	`{`
`402`	`402`	`return false;`
`403`	`403`	`}`
`@@ -516,7 +516,7 @@ inline bool QosPoliciesSerializer<HistoryQosPolicy>::read_content_from_cdr_messa`
`516`	`516`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`517`	`517`	`const uint16_t parameter_length)`
`518`	`518`	`{`
`519`		`- if (parameter_length != PARAMETER_KIND_LENGTH + 4)`
	`519`	`+ if (parameter_length < PARAMETER_KIND_LENGTH + 4)`
`520`	`520`	`{`
`521`	`521`	`return false;`
`522`	`522`	`}`
`@@ -553,7 +553,7 @@ inline bool QosPoliciesSerializer<DurabilityServiceQosPolicy>::read_content_from`
`553`	`553`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`554`	`554`	`const uint16_t parameter_length)`
`555`	`555`	`{`
`556`		`- if (parameter_length != PARAMETER_TIME_LENGTH + PARAMETER_KIND_LENGTH + 16)`
	`556`	`+ if (parameter_length < PARAMETER_TIME_LENGTH + PARAMETER_KIND_LENGTH + 16)`
`557`	`557`	`{`
`558`	`558`	`return false;`
`559`	`559`	`}`
`@@ -588,7 +588,7 @@ inline bool QosPoliciesSerializer<LifespanQosPolicy>::read_content_from_cdr_mess`
`588`	`588`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`589`	`589`	`const uint16_t parameter_length)`
`590`	`590`	`{`
`591`		`- if (parameter_length != PARAMETER_TIME_LENGTH)`
	`591`	`+ if (parameter_length < PARAMETER_TIME_LENGTH)`
`592`	`592`	`{`
`593`	`593`	`return false;`
`594`	`594`	`}`
`@@ -615,7 +615,7 @@ inline bool QosPoliciesSerializer<OwnershipStrengthQosPolicy>::read_content_from`
`615`	`615`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`616`	`616`	`const uint16_t parameter_length)`
`617`	`617`	`{`
`618`		`- if (parameter_length != 4)`
	`618`	`+ if (parameter_length < 4)`
`619`	`619`	`{`
`620`	`620`	`return false;`
`621`	`621`	`}`
`@@ -638,7 +638,7 @@ inline bool QosPoliciesSerializer<TransportPriorityQosPolicy>::read_content_from`
`638`	`638`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`639`	`639`	`const uint16_t parameter_length)`
`640`	`640`	`{`
`641`		`- if (parameter_length != 4)`
	`641`	`+ if (parameter_length < 4)`
`642`	`642`	`{`
`643`	`643`	`return false;`
`644`	`644`	`}`
`@@ -800,7 +800,7 @@ inline bool QosPoliciesSerializer<DisablePositiveACKsQosPolicy>::read_content_fr`
`800`	`800`	`fastrtps::rtps::CDRMessage_t* cdr_message,`
`801`	`801`	`const uint16_t parameter_length)`
`802`	`802`	`{`
`803`		`- if (parameter_length != PARAMETER_BOOL_LENGTH)`
	`803`	`+ if (parameter_length < PARAMETER_BOOL_LENGTH)`
`804`	`804`	`{`
`805`	`805`	`return false;`
`806`	`806`	`}`