Fix comparison in remove_from_pdp_reader_history (#4182) (#4185)

mergify[bot] · MiguelCompany · web-flow · commit 0b1b3777c00b · 2024-01-09T11:04:23.000+01:00
Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 6898d18) Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
diff --git a/src/cpp/rtps/builtin/discovery/participant/simple/SimplePDPEndpointsSecure.hpp b/src/cpp/rtps/builtin/discovery/participant/simple/SimplePDPEndpointsSecure.hpp
@@ -87,11 +87,11 @@ struct SimplePDPEndpointsSecure : public SimplePDPEndpoints
         assert(nullptr != change);
         if (change->writerGUID.entityId == fastrtps::rtps::c_EntityId_SPDPWriter)
         {
-            secure_reader.history_->remove_change(change);
+            SimplePDPEndpoints::remove_from_pdp_reader_history(change);
         }
         else
         {
-            SimplePDPEndpoints::remove_from_pdp_reader_history(change);
+            secure_reader.history_->remove_change(change);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -87,11 +87,11 @@ struct SimplePDPEndpointsSecure : public SimplePDPEndpoints`
`87`	`87`	`assert(nullptr != change);`
`88`	`88`	`if (change->writerGUID.entityId == fastrtps::rtps::c_EntityId_SPDPWriter)`
`89`	`89`	`{`
`90`		`- secure_reader.history_->remove_change(change);`
	`90`	`+ SimplePDPEndpoints::remove_from_pdp_reader_history(change);`
`91`	`91`	`}`
`92`	`92`	`else`
`93`	`93`	`{`
`94`		`- SimplePDPEndpoints::remove_from_pdp_reader_history(change);`
	`94`	`+ secure_reader.history_->remove_change(change);`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`