Some fmt fixes

Author: szmyd

include/sisl/logging/logging.h

@@ -134,7 +134,7 @@ constexpr const char* file_name(const char* const str) { return str_slant(str) ?
         fmt::memory_buffer _log_buf{};                                                                                 \
         const auto& cb{formatter};                                                                                     \
         [[likely]] if (cb(_log_buf, msg __VA_OPT__(, ) __VA_ARGS__)) {                                                 \
-            fmt::vformat_to(fmt::appender{_log_buf}, fmt::string_view{"{}"}, fmt::make_format_args('\0'));             \
+            fmt::format_to(fmt::appender{_log_buf}, fmt::string_view{"\0"});                                          \
             _l->method(_log_buf.data());                                                                               \
             if (is_flush) { _l->flush(); }                                                                             \
         }                                                                                                              \
@@ -145,7 +145,7 @@ constexpr const char* file_name(const char* const str) { return str_slant(str) ?
         fmt::memory_buffer _log_buf{};                                                                                 \
         const auto& cb{formatter};                                                                                     \
         if (LOGGING_PREDICT_TRUE(cb(_log_buf, msg __VA_OPT__(, ) __VA_ARGS__))) {                                      \
-            fmt::vformat_to(fmt::appender{_log_buf}, fmt::string_view{"{}"}, fmt::make_format_args('\0'));             \
+            fmt::format_to(fmt::appender{_log_buf}, fmt::string_view{"\0"});                                          \
             _l->method(_log_buf.data());                                                                               \
             if (is_flush) { _l->flush(); }                                                                             \
         }                                                                                                              \
@@ -495,9 +495,11 @@ template < typename T1, typename T2, typename T3, typename... Args >
 void _cmp_assert_with_msg(fmt::memory_buffer& buf, const char* const msg, T1&& val1, T2&& op, T3&& val2,
                           Args&&... args) {
 
+    auto val_1_cp = val1;
+    auto val_2_cp = val2;
     fmt::vformat_to(fmt::appender{buf},
                     fmt::string_view{"******************** Assertion failure: =====> Expected '{}' to be {} to '{}' "},
-                    fmt::make_format_args(std::forward< T1 >(val1), std::forward< T2 >(op), std::forward< T3 >(val2)));
+                    fmt::make_format_args(val_1_cp, std::forward< T2 >(op), val_2_cp));
     fmt::vformat_to(fmt::appender{buf}, fmt::string_view{msg}, fmt::make_format_args(std::forward< Args >(args)...));
 }
 

src/logging/logging.cpp

@@ -295,7 +295,7 @@ static std::string setup_modules() {
         const std::string& mod_name{glob_enabled_mods[mod_num]};
         fmt::vformat_to(
             std::back_inserter(out_str), fmt::string_view{"{}={}, "},
-            fmt::make_format_args(mod_name, spdlog::level::to_string_view(GetModuleLogLevel(mod_name)).data()));
+            fmt::make_format_args(mod_name, spdlog::level::to_string_view(GetModuleLogLevel(mod_name))));
     }
 
     return out_str;