Switch all the walkthroughs to the new, non-promisified interface

The changes are fairly straightforward.

Author: shankari

www/js/diary/detail.js

@@ -1,11 +1,11 @@
 'use strict';
 angular.module('emission.main.diary.detail',['ui-leaflet', 'ng-walkthrough',
-                                      'nvd3', 'angularLocalStorage',
+                                      'nvd3', 'emission.plugin.kvstore',
                                       'emission.services', 'emission.plugin.logger',
                                       'emission.incident.posttrip.manual'])
 
 .controller("DiaryDetailCtrl", function($scope, $rootScope, $window, $stateParams, $ionicActionSheet,
-                                        leafletData, leafletMapEvents, nzTour, storage,
+                                        leafletData, leafletMapEvents, nzTour, KVStore,
                                         Logger, Timeline, DiaryHelper, Config,
                                         CommHelper, PostTripManualMarker) {
   console.log("controller DiaryDetailCtrl called with params = "+
@@ -148,10 +148,10 @@ angular.module('emission.main.diary.detail',['ui-leaflet', 'ng-walkthrough',
 
   var checkDetailTutorialDone = function () {
     var DETAIL_DONE_KEY = 'detail_tutorial_done';
-    var detailTutorialDone = storage.get(DETAIL_DONE_KEY);
+    var detailTutorialDone = KVStore.getDirect(DETAIL_DONE_KEY);
     if (!detailTutorialDone) {
       startWalkthrough();
-      storage.set(DETAIL_DONE_KEY, true);
+      KVStore.set(DETAIL_DONE_KEY, true);
     }
   };
 

www/js/diary/list.js

@@ -5,7 +5,7 @@ angular.module('emission.main.diary.list',['ui-leaflet',
                                       'emission.main.common.services',
                                       'emission.incident.posttrip.manual',
                                       'emission.services',
-                                      'ng-walkthrough', 'nzTour', 'angularLocalStorage',
+                                      'ng-walkthrough', 'nzTour', 'emission.plugin.kvstore',
                                       'emission.plugin.logger'])
 
 .controller("DiaryListCtrl", function($window, $scope, $rootScope, $ionicPlatform, $state,
@@ -14,7 +14,7 @@ angular.module('emission.main.diary.list',['ui-leaflet',
                                     $ionicActionSheet,
                                     ionicDatePicker,
                                     leafletData, Timeline, CommonGraph, DiaryHelper,
-                                    Config, PostTripManualMarker, nzTour, storage, Logger) {
+                                    Config, PostTripManualMarker, nzTour, KVStore, Logger) {
   console.log("controller DiaryListCtrl called");
   // Add option
 
@@ -341,10 +341,10 @@ angular.module('emission.main.diary.list',['ui-leaflet',
     */
     var checkDiaryTutorialDone = function () {
       var DIARY_DONE_KEY = 'diary_tutorial_done';
-      var diaryTutorialDone = storage.get(DIARY_DONE_KEY);
+      var diaryTutorialDone = KVStore.getDirect(DIARY_DONE_KEY);
       if (!diaryTutorialDone) {
         startWalkthrough();
-        storage.set(DIARY_DONE_KEY, true);
+        KVStore.set(DIARY_DONE_KEY, true);
       }
     };
 

www/js/heatmap.js

@@ -2,11 +2,11 @@
 
 angular.module('emission.main.heatmap',['ui-leaflet', 'emission.services',
                'emission.plugin.logger', 'emission.incident.posttrip.manual',
-               'ng-walkthrough', 'nzTour', 'angularLocalStorage'])
+               'ng-walkthrough', 'nzTour', 'emission.plugin.kvstore'])
 
 .controller('HeatmapCtrl', function($scope, $ionicLoading, $ionicActionSheet, $http,
         leafletData, Logger, Config, PostTripManualMarker,
-        $window, nzTour, storage) {
+        $window, nzTour, KVStore) {
   $scope.mapCtrl = {};
 
   angular.extend($scope.mapCtrl, {
@@ -371,10 +371,10 @@ angular.module('emission.main.heatmap',['ui-leaflet', 'emission.services',
   */
   var checkHeatmapTutorialDone = function () {
     var HEATMAP_DONE_KEY = 'heatmap_tutorial_done';
-    var heatmapTutorialDone = storage.get(HEATMAP_DONE_KEY);
+    var heatmapTutorialDone = KVStore.getDirect(HEATMAP_DONE_KEY);
     if (!heatmapTutorialDone) {
       startWalkthrough();
-      storage.set(HEATMAP_DONE_KEY, true);
+      KVStore.set(HEATMAP_DONE_KEY, true);
     }
   };
 

www/js/incident/post-trip-map-display.js

@@ -1,13 +1,13 @@
 'use strict';
 angular.module('emission.incident.posttrip.map',['ui-leaflet', 'ng-walkthrough',
-                                      'angularLocalStorage',
+                                      'emission.plugin.kvstore',
                                       'emission.services', 'emission.plugin.logger',
                                       'emission.main.diary.services',
                                       'emission.incident.posttrip.manual'])
 
 .controller("PostTripMapCtrl", function($scope, $window, $state,
                                         $stateParams, $ionicLoading,
-                                        leafletData, leafletMapEvents, nzTour, storage,
+                                        leafletData, leafletMapEvents, nzTour, KVStore,
                                         Logger, Timeline, DiaryHelper, Config,
                                         UnifiedDataLoader, PostTripManualMarker) {
   Logger.log("controller PostTripMapDisplay called with params = "+
@@ -183,10 +183,10 @@ angular.module('emission.incident.posttrip.map',['ui-leaflet', 'ng-walkthrough',
 
   var checkIncidentTutorialDone = function () {
     var INCIDENT_DONE_KEY = 'incident_tutorial_done';
-    var incidentTutorialDone = storage.get(INCIDENT_DONE_KEY);
+    var incidentTutorialDone = KVStore.getDirect(INCIDENT_DONE_KEY);
     if (!incidentTutorialDone) {
       startWalkthrough();
-      storage.set(INCIDENT_DONE_KEY, true);
+      KVStore.set(INCIDENT_DONE_KEY, true);
     }
   };