Skip to content

Incorrect Function Signature #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dwmkerr opened this issue Oct 1, 2014 · 1 comment
Closed

Incorrect Function Signature #50

dwmkerr opened this issue Oct 1, 2014 · 1 comment
Labels
critical-todo critical bug/problem that the devs need to work on
Milestone
Release 2.2

Comments

@dwmkerr
Copy link
Owner

dwmkerr commented Oct 1, 2014

See: http://www.codeproject.com/Articles/533948/NET-Shell-Extensions-Shell-Preview-Handlers?msg=4913111#xx4913111xx

In the sources I downloaded from GitHub IPreviewHandler.SetRect takes a RECT but it should be a ref RECT. The result was nonsense rectangles on a resize which prevented the preview handler from being redrawn.

Otherwise great code. Many thanks.
@dwmkerr dwmkerr added the critical-todo critical bug/problem that the devs need to work on label Oct 1, 2014
@dwmkerr dwmkerr added this to the Release 2.2 milestone Oct 1, 2014
@dwmkerr
Copy link
Owner Author

dwmkerr commented Nov 22, 2014

Fixed

@dwmkerr dwmkerr closed this as completed Nov 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical-todo critical bug/problem that the devs need to work on
Projects
None yet
Milestone
Release 2.2
Development

No branches or pull requests
1 participant
@dwmkerr