feat: send HTTP api call now also supports setting the bundle processing control flags

Author: gh0st42

core/dtn7/src/dtnd/httpd.rs

@@ -467,21 +467,33 @@ async fn send_post(
 ) -> Result<String, (StatusCode, &'static str)> {
     let mut dst: EndpointID = EndpointID::none();
     let mut lifetime = std::time::Duration::from_secs(60 * 60);
+    let mut flags = BundleControlFlags::BUNDLE_MUST_NOT_FRAGMENTED;
+    //    | BundleControlFlags::BUNDLE_STATUS_REQUEST_DELIVERY;
+
     for (k, v) in query_params.iter() {
         if k == "dst" {
             dst = v.as_str().try_into().unwrap();
         } else if k == "lifetime" {
             if let Ok(dur) = humantime::parse_duration(v) {
                 lifetime = dur;
             }
+        } else if k == "flags" {
+            let param_flags: u64 = v.as_str().parse().unwrap_or(0);
+            if let Some(bpcf) = BundleControlFlags::from_bits(param_flags) {
+                flags = bpcf;
+            } else {
+                return Err((
+                    StatusCode::BAD_REQUEST,
+                    "Invalid Bundle Processing Control Flags!",
+                ));
+            }
         }
     }
     if dst == EndpointID::none() {
         return Err((StatusCode::BAD_REQUEST, "Missing destination endpoint id!"));
     }
     let src = CONFIG.lock().host_eid.clone();
-    let flags = BundleControlFlags::BUNDLE_MUST_NOT_FRAGMENTED
-        | BundleControlFlags::BUNDLE_STATUS_REQUEST_DELIVERY;
+
     let pblock = bp7::primary::PrimaryBlockBuilder::default()
         .bundle_control_flags(flags.bits())
         .destination(dst)
@@ -508,12 +520,12 @@ async fn send_post(
 
     debug!(
         "Sending bundle {} to {}",
-        bndl.id(),
+        &bndl.id(),
         bndl.primary.destination
     );
-
+    let bid = bndl.id();
     crate::core::processing::send_bundle(bndl).await;
-    Ok(format!("Sent payload with {} bytes", b_len))
+    Ok(format!("Sent ADU in bundle {} with {} bytes", bid, b_len))
 }
 
 //#[post("/push")]

core/dtn7/src/dtnd/ws.rs

@@ -363,6 +363,7 @@ impl WsAASession {
                         }
                     }
                     WsReceiveMode::Data(format) => {
+                        // TODO: make BPCF configurable via WsSendData
                         let send_data = match format {
                             DataReceiveFormat::CBOR => serde_cbor::from_slice::<WsSendData>(&bin)
                                 .map_err(|_| "error parsing cbor"),

doc/http-client-api.md

@@ -16,11 +16,12 @@ This is meant to be viewed with a standard web browser such as firefox, chrome,
 
 These API endpoints can only be called from localhost for security reasons.
 
-### **POST** `/send?dst=<EID>&lifetime=<LIFETIME>`
+### **POST** `/send?dst=<EID>&lifetime=<LIFETIME>&flags=<BPCF>`
 
 Construct a new bundle with the given parameters. 
 The bundle payload is sent as the body of the *POST* request.
 The URL parameters `dst` and `lifetime` are used to set the corresponding bundle fields.
+The [Bundle Processing Control Flags](https://www.rfc-editor.org/rfc/rfc9171.html#name-bundle-processing-control-f) can be set as an unsigned integer via the `flags` parameter.
 
 ```
 $ curl -X POST -d 'hello world' "http://127.0.0.1:3000/send?dst=dtn://node3/incoming&lifetime=5m"