SqlSetup\Set-TargetResource Unit Tests very slow to execute

[dan-hughes]

This is not something that happens to me locally but on Azure DevOps the tests are taking 20+ seconds each to run.

[johlju]

I have refactored the tests for that resource when converting to Pester 5. They were extremely complex then, but the tests are still very complex now. As I recall they run slow for me as well on my PC.

I think only way to fix it is to do a refactor again, but not sure if it is worth it? Most likely, but only guessing, it is a mocking thing connected to a ForEach-testcases. 🤔

Before when I have seen time differences it is because mocking is not done at the first level, but second or third level (command call "nesting level"). Not sure if it was in Pester 5, maybe Pester 4. 🤔 But could also be a bug in the tests somewhere that not showing up in Azure DevOps for some reason. There were actually a mocking bug in the Pester 4 tests that prevented me to run the tests locally, but they passed in Azure DevOps. I never understood why. But I fixed it in Pester 5 tests.

Anyway. I have for the past 2-3 years worked on refactoring this resource into a new SqlInstall that uses public commands (and the goal is to make it faster) to do things. To move out most logic to separate units to run an tests so it wouldn't be so complex. But that worked has stalled as it takes a lot of time as I need to test everything live in VM's.
PR for SqlInstall: #1912