Remove enum ReportServerEdition

johlju · johlju · commit 51cab16e0940 · 2025-05-01T13:00:31.000+02:00
diff --git a/source/Classes/020.SqlRSSetup.ps1 b/source/Classes/020.SqlRSSetup.ps1
@@ -187,7 +187,8 @@ class SqlRSSetup : ResourceBase
     $EditionUpgrade
 
     [DscProperty()]
-    [ReportServerEdition]
+    [ValidateSet('Developer', 'Evaluation', 'ExpressAdvanced')]
+    [System.String]
     $Edition
 
     [DscProperty()]
diff --git a/source/Enum/001.ReportServerEdition.ps1 b/source/Enum/001.ReportServerEdition.ps1
diff --git a/tests/Unit/Classes/SqlRSSetup.Tests.ps1 b/tests/Unit/Classes/SqlRSSetup.Tests.ps1
@@ -129,8 +129,7 @@ Describe 'SqlRSSetup\Get()' -Tag 'Get' {
                     $currentState.MediaPath | Should -BeNullOrEmpty
                     $currentState.ProductKey | Should -BeNullOrEmpty
                     $currentState.EditionUpgrade | Should -BeNullOrEmpty
-                    # Returns 0, that means no value was set by GetCurrentState() from the enum ReportServerEdition
-                    $currentState.Edition | Should -Be 0
+                    $currentState.Edition | Should -BeNullOrEmpty
                     $currentState.LogPath | Should -BeNullOrEmpty
                     $currentState.InstallFolder | Should -BeNullOrEmpty
                     $currentState.SuppressRestart | Should -BeFalse
@@ -188,8 +187,7 @@ Describe 'SqlRSSetup\Get()' -Tag 'Get' {
                     $currentState.MediaPath | Should -BeNullOrEmpty
                     $currentState.ProductKey | Should -BeNullOrEmpty
                     $currentState.EditionUpgrade | Should -BeNullOrEmpty
-                    # Returns 0, that means no value was set by GetCurrentState() from the enum ReportServerEdition
-                    $currentState.Edition | Should -Be 0
+                    $currentState.Edition | Should -BeNullOrEmpty
                     $currentState.LogPath | Should -BeNullOrEmpty
                     $currentState.InstallFolder | Should -BeNullOrEmpty
                     $currentState.SuppressRestart | Should -BeFalse
