Skip to content

Commit 1bf09ec

Browse files
authored
Fix localization hqrm (#2050)
1 parent 5677cd5 commit 1bf09ec

File tree

5 files changed

+32
-7
lines changed

5 files changed

+32
-7
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
55

66
## [Unreleased]
77

8+
### Changed
9+
810
- SqlSetup
911
- Fixed issue with AddNode where cluster IP information was not being passed to
1012
setup.exe. ([issue #1171](https://github.com/dsccommunity/SqlServerDsc/issues/1171))
1113

14+
### Fixed
15+
16+
- SqlServerDsc
17+
- Fix localization tests.
18+
1219
## [17.0.0] - 2024-09-30
1320

1421
### Added

RequiredModules.psd1

+7-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,13 @@
3636
'DscResource.Common' = 'latest'
3737

3838
# Analyzer rules
39-
'DscResource.AnalyzerRules' = 'latest'
39+
'DscResource.AnalyzerRules' = @{
40+
Version = 'latest'
41+
Parameters = @{
42+
AllowPrerelease = $true
43+
}
44+
}
45+
4046
'Indented.ScriptAnalyzerRules' = 'latest'
4147

4248
# Dependency for integration tests

build.yaml

+12-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ BuildWorkflow:
1414
- Create_Changelog_Release_Output
1515

1616
docs:
17+
- Clean_WikiContent_Folder
1718
- Check_SqlServer_Availability
1819
- Generate_Conceptual_Help
1920
- Generate_Wiki_Content
@@ -46,13 +47,22 @@ BuildWorkflow:
4647
try
4748
{
4849
[Microsoft.SqlServer.Management.Smo.Server] -as [Type] | Out-Null
50+
[Microsoft.SqlServer.Management.Smo.Wmi.Service] -as [Type] | Out-Null
4951
}
5052
catch
5153
{
52-
throw 'The SqlServer types are not available. Please install the SqlServer module or load SMO stubs types and try again.'
54+
Write-Error -Message "Both the SqlServer namespaces Microsoft.SqlServer.Management.Smo or Microsoft.SqlServer.Management.Smo.Wmi are not available. Please install the SqlServer module.`nBy using PSResourceGet: Save-PSResource -Name SqlServer -Prerelease -Repository PSGallery -TrustRepository -Path .\output\RequiredModules\" -ErrorAction 'Stop'
5355
}
5456
}
5557
58+
Clean_WikiContent_Folder: |
59+
{
60+
# Clean output/WikiContent folder
61+
if (Test-Path -Path './output/WikiContent')
62+
{
63+
Remove-Item -Path './output/WikiContent' -Recurse -Force
64+
}
65+
}
5666
####################################################
5767
# ModuleBuilder Configuration #
5868
####################################################
@@ -188,7 +198,7 @@ DscResource.DocGenerator:
188198
- '\*(.+?)\*' # Match Italic (asterisk)
189199
Publish_GitHub_Wiki_Content:
190200
Debug: false
191-
Generate_Wiki_Content:
201+
Generate_Markdown_For_DSC_Resources:
192202
MofResourceMetadata:
193203
Type: MofResource
194204
Category: Resources

source/Modules/SqlServerDsc.Common/SqlServerDsc.Common.psm1

+1-3
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,7 @@ function Test-PendingRestart
358358
{
359359
[CmdletBinding()]
360360
[OutputType([System.Boolean])]
361-
param
362-
(
363-
)
361+
param ()
364362

365363
$getRegistryPropertyValueParameters = @{
366364
Path = 'HKLM:\SYSTEM\CurrentControlSet\Control\Session Manager'

source/WikiSource/CredentialOverview.md renamed to source/WikiSource/Credential-overview.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
# Credential Overview
1+
---
2+
Category: Usage
3+
---
4+
5+
# Credential overview
26

37
## Group Managed Service Account
48

0 commit comments

Comments
 (0)