xActiveDirectory: Fix Script Analyzer Rule Failures (#303)

- Changes to xActiveDirectory
  - Fix Script Analyzer rule failures
  - Opt-in to "Common Tests - Custom Script Analyzer Rules"
  - Opt-in to "Common Tests - Required Script Analyzer Rules"
  - Opt-in to "Common Tests - Flagged Script Analyzer Rules"

Author: X-Guardian

.MetaTestOptIn.json

@@ -1,3 +1,6 @@
 [
-        "Common Tests - Validate Markdown Files"
+        "Common Tests - Validate Markdown Files",
+        "Common Tests - Custom Script Analyzer Rules",
+        "Common Tests - Required Script Analyzer Rules",
+        "Common Tests - Flagged Script Analyzer Rules"
 ]

CHANGELOG.md

@@ -9,6 +9,10 @@
     - Compare-ResourcePropertyState
     - Test-DscPropertyState
   - Move the examples in the README.md to Examples folder
+  - Fix Script Analyzer rule failures
+  - Opt-in to "Common Tests - Custom Script Analyzer Rules"
+  - Opt-in to "Common Tests - Required Script Analyzer Rules"
+  - Opt-in to "Common Tests - Flagged Script Analyzer Rules"
 - Changes to xADComputer
   - Refactored the resource and the unit tests.
   - BREAKING CHANGE: The `Enabled` property is **DEPRECATED** and is no

DSCResources/MSFT_xADDomainDefaultPasswordPolicy/MSFT_xADDomainDefaultPasswordPolicy.psm1

@@ -38,7 +38,7 @@ function Get-TargetResource
     [OutputType([System.Collections.Hashtable])]
     param
     (
-        [Parameter(Mandatory)]
+        [Parameter(Mandatory = $true)]
         [System.String] $DomainName,
 
         [Parameter()]
@@ -77,7 +77,7 @@ function Test-TargetResource
     [OutputType([System.Boolean])]
     param
     (
-        [Parameter(Mandatory)]
+        [Parameter(Mandatory = $true)]
         [System.String] $DomainName,
 
         [Parameter()]
@@ -163,7 +163,7 @@ function Set-TargetResource
     [CmdletBinding()]
     param
     (
-        [Parameter(Mandatory)]
+        [Parameter(Mandatory = $true)]
         [System.String] $DomainName,
 
         [Parameter()]